From: W.C.A. Wijngaards Date: Thu, 9 Jul 2020 14:37:40 +0000 (+0200) Subject: stream reuse, comment improved X-Git-Tag: release-1.13.0rc1~5^2~41 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ad6fa1eb4531a97a785fd198f0b4993600926096;p=thirdparty%2Funbound.git stream reuse, comment improved --- diff --git a/services/outside_network.c b/services/outside_network.c index f899bfd43..a33507dd0 100644 --- a/services/outside_network.c +++ b/services/outside_network.c @@ -827,7 +827,9 @@ static void reuse_cb_readwait_for_failure(struct pending_tcp* pend, int err) /** perform callbacks for failure and also decommission pending tcp. * the callbacks remove references in sq->pending to the waiting_tcp - * members of the tree_by_id in the pending tcp. */ + * members of the tree_by_id in the pending tcp. The pending_tcp is + * removed before the callbacks, so that the callbacks do not modify + * the pending_tcp due to its reference in the outside_network reuse tree */ static void reuse_cb_and_decommission(struct outside_network* outnet, struct pending_tcp* pend, int error) {