From: Marc Foley <m.foley.88@gmail.com>
Date: Tue, 21 Jun 2022 14:09:32 +0000 (+0100)
Subject: build_fvar_instances: support fonts which lack wght axis
X-Git-Tag: v0.3.0^0
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ad98e3c12ad8da84df062464275ec2633db8eedb;p=thirdparty%2Fgoogle%2Ffonts.git

build_fvar_instances: support fonts which lack wght axis
---

diff --git a/Lib/axisregistry/__init__.py b/Lib/axisregistry/__init__.py
index 198cdc5df1..ea54848113 100644
--- a/Lib/axisregistry/__init__.py
+++ b/Lib/axisregistry/__init__.py
@@ -307,16 +307,21 @@ def build_fvar_instances(ttFont, axis_dflts={}):
     is_italic = "Italic" in style_name
     is_roman_and_italic = any(a for a in ("slnt", "ital") if a in fvar_dflts)
 
+    fallbacks = axis_registry.fallbacks_in_fvar(ttFont)
+    # some families may not have a wght axis e.g
+    # https://fonts.google.com/specimen/League+Gothic
+    # these families just have a single weight which is Regular
     if "wght" not in fvar_dflts:
-        # TODO
-        raise NotImplementedError()
+        fallback = next(
+            (f for f in axis_registry["wght"].fallback if f.value == 400.0), None
+        )
+        fallbacks["wght"] = [fallback]
+
+    wght_fallbacks = fallbacks["wght"]
 
     ital_axis = next((a for a in fvar.axes if a.axisTag == "ital"), None)
     slnt_axis = next((a for a in fvar.axes if a.axisTag == "slnt"), None)
 
-    fallbacks = axis_registry.fallbacks_in_fvar(ttFont)
-    wght_fallbacks = fallbacks["wght"]
-
     def gen_instances(is_italic):
         results = []
         for fallback in wght_fallbacks:
@@ -324,7 +329,8 @@ def build_fvar_instances(ttFont, axis_dflts={}):
             name = name.replace("Regular Italic", "Italic")
 
             coordinates = {k: v for k, v in axis_dflts.items()}
-            coordinates["wght"] = fallback.value
+            if "wght" in fvar_dflts:
+                coordinates["wght"] = fallback.value
             if is_italic:
                 if ital_axis:
                     coordinates["ital"] = ital_axis.minValue