From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Wed, 6 Dec 2017 20:48:37 +0000 (+0100)
Subject: coverity: #1425742
X-Git-Tag: lxc-3.0.0.beta1~129^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=adcdf4e4a70eb8ea52508867591e401d17292036;p=thirdparty%2Flxc.git

coverity: #1425742

fix error condition check

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/storage/overlay.c b/src/lxc/storage/overlay.c
index 0efefbee5..356874bb4 100644
--- a/src/lxc/storage/overlay.c
+++ b/src/lxc/storage/overlay.c
@@ -545,7 +545,7 @@ int ovl_mount(struct lxc_storage *bdev)
 	upper++;
 
 	/* if delta doesn't yet exist, create it */
-	ret = mkdir_p(upper, 0755) < 0;
+	ret = mkdir_p(upper, 0755);
 	if (ret < 0 && errno != EEXIST) {
 		SYSERROR("Failed to create directory \"%s\"", upper);
 		free(dup);