From: Christoph Hellwig Date: Fri, 25 Feb 2022 18:14:40 +0000 (+0100) Subject: block: default BLOCK_LEGACY_AUTOLOAD to y X-Git-Tag: v5.15.186~57 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=add2a8e193f371fef6b2f8b785dd9e5aa04df729;p=thirdparty%2Fkernel%2Fstable.git block: default BLOCK_LEGACY_AUTOLOAD to y commit 451f0b6f4c44d7b649ae609157b114b71f6d7875 upstream. As Luis reported, losetup currently doesn't properly create the loop device without this if the device node already exists because old scripts created it manually. So default to y for now and remove the aggressive removal schedule. Reported-by: Luis Chamberlain Signed-off-by: Christoph Hellwig Reviewed-by: Chaitanya Kulkarni Link: https://lore.kernel.org/r/20220225181440.1351591-1-hch@lst.de Signed-off-by: Jens Axboe Cc: Sebastian Priebe Link: https://lore.kernel.org/r/ZR0P278MB097497EF6CFD85E72819447E9F70A@ZR0P278MB0974.CHEP278.PROD.OUTLOOK.COM Signed-off-by: Greg Kroah-Hartman --- diff --git a/block/Kconfig b/block/Kconfig index 0d415226e3daa..ee4c543b1c337 100644 --- a/block/Kconfig +++ b/block/Kconfig @@ -28,15 +28,13 @@ if BLOCK config BLOCK_LEGACY_AUTOLOAD bool "Legacy autoloading support" + default y help Enable loading modules and creating block device instances based on accesses through their device special file. This is a historic Linux feature and makes no sense in a udev world where device files are - created on demand. - - Say N here unless booting or other functionality broke without it, in - which case you should also send a report to your distribution and - linux-block@vger.kernel.org. + created on demand, but scripts that manually create device nodes and + then call losetup might rely on this behavior. config BLK_RQ_ALLOC_TIME bool diff --git a/block/bdev.c b/block/bdev.c index 85c090ef3bf2c..ce7c20c266179 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -741,7 +741,7 @@ struct block_device *blkdev_get_no_open(dev_t dev) inode = ilookup(blockdev_superblock, dev); if (inode) pr_warn_ratelimited( -"block device autoloading is deprecated. It will be removed in Linux 5.19\n"); +"block device autoloading is deprecated and will be removed.\n"); } if (!inode) return NULL;