From: Rainer Jung Date: Tue, 9 Feb 2016 23:09:24 +0000 (+0000) Subject: Add APLOGNO, first chunk (those that were X-Git-Tag: 2.4.19~213 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aded325d60a261bfe6fa3c38427e7ec56a33b1b5;p=thirdparty%2Fapache%2Fhttpd.git Add APLOGNO, first chunk (those that were detected by coccinelle). There are some more but they are easier to backport once these here are applied. Backport of r1725392, r1725394, r1725395 and r1725468 from trunk. Submitted by: rjung Reviewed by: jim, ylavic git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1729495 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/CHANGES b/CHANGES index ff00b15f35c..e7dd9081c4a 100644 --- a/CHANGES +++ b/CHANGES @@ -22,6 +22,9 @@ Changes with Apache 2.4.19 *) mime.types: add common extension "m4a" for MPEG 4 Audio. PR 57895 [Dylan Millikin ] + *) Added many log numbers to log statements that had none. + [Rainer Jung] + *) mod_log_config: Add GlobalLog to allow a globally defined log to be inherited by virtual hosts that define a CustomLog. [Edward Lu] diff --git a/STATUS b/STATUS index 961f81a919c..016f170020f 100644 --- a/STATUS +++ b/STATUS @@ -134,20 +134,6 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK: trunk patch: http://svn.apache.org/r1725940 +1: icing, jim, ylavic - *) Add APLOGNO, first chunk (those that were detected by coccinelle). - There are some more but they are easier to backport once these here are applied. - trunk patch: http://svn.apache.org/r1725392 (modules) - http://svn.apache.org/r1725394 (server/mpm) - http://svn.apache.org/r1725395 (server others) - http://svn.apache.org/r1725468 (remove APLOGNO from mod_log_debug custom messages) - 2.4.x patch: http://people.apache.org/~rjung/patches/aplogno-backport-r1725392.patch - http://people.apache.org/~rjung/patches/aplogno-backport-r1725394.patch - http://people.apache.org/~rjung/patches/aplogno-backport-r1725395.patch - http://people.apache.org/~rjung/patches/aplogno-backport-r1725468.patch - +1: rjung, jim, ylavic - icing: needs http://svn.apache.org/r1725468 - rjung: You are right, I added r1725468 and restarted the vote. - *) core: Prevent a server crash in case of an invalid CONNECT request with a custom error page for status code 400 that uses server side includes. PR 58929 diff --git a/modules/aaa/mod_auth_form.c b/modules/aaa/mod_auth_form.c index 263c8e63d8a..2306ab1de65 100644 --- a/modules/aaa/mod_auth_form.c +++ b/modules/aaa/mod_auth_form.c @@ -683,7 +683,7 @@ static int get_form_auth(request_rec * r, /* a missing username or missing password means auth denied */ if (!sent_user || !*sent_user) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02982) "form parsed, but username field '%s' was missing or empty, unauthorized", username); @@ -691,7 +691,7 @@ static int get_form_auth(request_rec * r, } if (!sent_pw || !*sent_pw) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02983) "form parsed, but password field '%s' was missing or empty, unauthorized", password); diff --git a/modules/arch/win32/mod_isapi.c b/modules/arch/win32/mod_isapi.c index 66cc8da69ed..275d0864ef7 100644 --- a/modules/arch/win32/mod_isapi.c +++ b/modules/arch/win32/mod_isapi.c @@ -842,7 +842,7 @@ static int APR_THREAD_FUNC regfnWriteClient(isapi_cid *cid, rv = ap_pass_brigade(r->output_filters, bb); cid->response_sent = 1; if (rv != APR_SUCCESS) - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r, APLOGNO(02984) "WriteClient ap_pass_brigade failed: %s", r->filename); } @@ -1017,7 +1017,7 @@ static int APR_THREAD_FUNC regfnServerSupportFunction(isapi_cid *cid, r->args = apr_pstrdup(r->pool, (char*) buf_data); } if (cid->dconf.log_to_errlog) - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(02985) "%s: %s", cid->r->filename, (char*) buf_data); return 1; @@ -1187,9 +1187,9 @@ static int APR_THREAD_FUNC regfnServerSupportFunction(isapi_cid *cid, int res = 0; if (!cid->dconf.fake_async) { if (cid->dconf.log_unsupported) - ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, - "asynchronous I/O not supported: %s", - r->filename); + ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, APLOGNO(02986) + "asynchronous I/O not supported: %s", + r->filename); apr_set_os_error(APR_FROM_OS_ERROR(ERROR_INVALID_PARAMETER)); return 0; } diff --git a/modules/core/mod_macro.c b/modules/core/mod_macro.c index ec484ac966e..4cd1d41256e 100644 --- a/modules/core/mod_macro.c +++ b/modules/core/mod_macro.c @@ -115,7 +115,7 @@ static void warn_if_non_blank(const char * what, if (*p == '#') break; if (*p != ' ' && *p != '\t') { - ap_log_error(APLOG_MARK, APLOG_WARNING, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING, 0, NULL, APLOGNO(02989) "%s on line %d of %s: %s", what, cfg->line_number, cfg->name, ptr); break; diff --git a/modules/examples/mod_example_hooks.c b/modules/examples/mod_example_hooks.c index 4db0865cccb..d818dc1f73a 100644 --- a/modules/examples/mod_example_hooks.c +++ b/modules/examples/mod_example_hooks.c @@ -328,7 +328,8 @@ static x_cfg *our_cconfig(const conn_rec *c) static void example_log_each(apr_pool_t *p, server_rec *s, const char *note) { if (s != NULL) { - ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, "mod_example_hooks: %s", note); + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, APLOGNO(02991) + "mod_example_hooks: %s", note); } else { apr_file_t *out = NULL; diff --git a/modules/examples/mod_example_ipc.c b/modules/examples/mod_example_ipc.c index a7cdb34d1bb..9685f8fc33e 100644 --- a/modules/examples/mod_example_ipc.c +++ b/modules/examples/mod_example_ipc.c @@ -142,7 +142,7 @@ static int exipc_post_config(apr_pool_t *pconf, apr_pool_t *plog, */ rs = apr_temp_dir_get(&tempdir, pconf); if (APR_SUCCESS != rs) { - ap_log_error(APLOG_MARK, APLOG_ERR, rs, s, + ap_log_error(APLOG_MARK, APLOG_ERR, rs, s, APLOGNO(02992) "Failed to find temporary directory"); return HTTP_INTERNAL_SERVER_ERROR; } @@ -160,7 +160,7 @@ static int exipc_post_config(apr_pool_t *pconf, apr_pool_t *plog, rs = apr_shm_create(&exipc_shm, sizeof(exipc_data), (const char *) shmfilename, pconf); if (APR_SUCCESS != rs) { - ap_log_error(APLOG_MARK, APLOG_ERR, rs, s, + ap_log_error(APLOG_MARK, APLOG_ERR, rs, s, APLOGNO(02993) "Failed to create shared memory segment on file %s", shmfilename); return HTTP_INTERNAL_SERVER_ERROR; @@ -205,7 +205,7 @@ static void exipc_child_init(apr_pool_t *p, server_rec *s) apr_global_mutex_lockfile(exipc_mutex), p); if (APR_SUCCESS != rs) { - ap_log_error(APLOG_MARK, APLOG_CRIT, rs, s, + ap_log_error(APLOG_MARK, APLOG_CRIT, rs, s, APLOGNO(02994) "Failed to reopen mutex %s in child", exipc_mutex_type); /* There's really nothing else we can do here, since This @@ -265,7 +265,7 @@ static int exipc_handler(request_rec *r) } else { /* Some error, log and bail */ - ap_log_error(APLOG_MARK, APLOG_ERR, rs, r->server, + ap_log_error(APLOG_MARK, APLOG_ERR, rs, r->server, APLOGNO(02995) "Child %ld failed to acquire lock", (long int)getpid()); break; /* Out of the loop without having the lock */ @@ -273,7 +273,7 @@ static int exipc_handler(request_rec *r) } else { /* Some other error, log and bail */ - ap_log_error(APLOG_MARK, APLOG_ERR, rs, r->server, + ap_log_error(APLOG_MARK, APLOG_ERR, rs, r->server, APLOGNO(02996) "Child %ld failed to try and acquire lock", (long int)getpid()); break; /* Out of the loop without having the lock */ diff --git a/modules/filters/mod_charset_lite.c b/modules/filters/mod_charset_lite.c index d991c12bbd9..ed76f611042 100644 --- a/modules/filters/mod_charset_lite.c +++ b/modules/filters/mod_charset_lite.c @@ -508,7 +508,7 @@ static void log_xlate_error(ap_filter_t *f, apr_status_t rv) default: msg = APLOGNO(02198) "xlate filter - returning error"; } - ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, f->r, "%s", msg); + ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, f->r, APLOGNO(02997) "%s", msg); } /* chk_filter_chain() is called once per filter instance; it tries to diff --git a/modules/filters/mod_sed.c b/modules/filters/mod_sed.c index c49bad28bd7..346c210349d 100644 --- a/modules/filters/mod_sed.c +++ b/modules/filters/mod_sed.c @@ -64,7 +64,7 @@ module AP_MODULE_DECLARE_DATA sed_module; static apr_status_t log_sed_errf(void *data, const char *error) { request_rec *r = (request_rec *) data; - ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "%s", error); + ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(02998) "%s", error); return APR_SUCCESS; } diff --git a/modules/http2/h2_alt_svc.c b/modules/http2/h2_alt_svc.c index 2ccea963c15..24a8b1f41ad 100644 --- a/modules/http2/h2_alt_svc.c +++ b/modules/http2/h2_alt_svc.c @@ -102,7 +102,7 @@ static int h2_alt_svc_handler(request_rec *r) if (ma >= 0) { svc_ma = apr_psprintf(r->pool, "; ma=%d", ma); } - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03043) "h2_alt_svc: announce %s for %s:%d", (secure? "secure" : "insecure"), r->hostname, (int)r->server->port); diff --git a/modules/http2/h2_conn.c b/modules/http2/h2_conn.c index 3e762f162b4..f2cbbda0740 100644 --- a/modules/http2/h2_conn.c +++ b/modules/http2/h2_conn.c @@ -186,7 +186,7 @@ apr_status_t h2_conn_run(struct h2_ctx *ctx, conn_rec *c) c->cs->state = CONN_STATE_WRITE_COMPLETION; } if (APR_STATUS_IS_EOF(status)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, c, APLOGNO(03045) "h2_session(%ld): process, closing conn", c->id); c->keepalive = AP_CONN_CLOSE; } diff --git a/modules/http2/h2_conn_io.c b/modules/http2/h2_conn_io.c index 773d7bbb4b1..1ac1edc6668 100644 --- a/modules/http2/h2_conn_io.c +++ b/modules/http2/h2_conn_io.c @@ -112,7 +112,7 @@ static apr_status_t pass_out(apr_bucket_brigade *bb, void *ctx) ap_update_child_status(c->sbh, SERVER_BUSY_WRITE, NULL); status = apr_brigade_length(bb, 0, &bblen); if (status == APR_SUCCESS) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03044) "h2_conn_io(%ld): pass_out brigade %ld bytes", c->id, (long)bblen); status = ap_pass_brigade(c->output_filters, bb); diff --git a/modules/http2/h2_filter.c b/modules/http2/h2_filter.c index aaa3601133d..9bc550004b9 100644 --- a/modules/http2/h2_filter.c +++ b/modules/http2/h2_filter.c @@ -161,7 +161,7 @@ apr_status_t h2_filter_core_input(ap_filter_t* f, case APR_TIMEUP: break; default: - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, f->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, f->c, APLOGNO(03046) "h2_conn_io: error reading"); break; } diff --git a/modules/http2/h2_from_h1.c b/modules/http2/h2_from_h1.c index f2f39f307a5..e9b2fe309c4 100644 --- a/modules/http2/h2_from_h1.c +++ b/modules/http2/h2_from_h1.c @@ -519,7 +519,7 @@ apr_status_t h2_response_output_filter(ap_filter_t *f, apr_bucket_brigade *bb) if (eb) { int st = eb->status; apr_brigade_cleanup(bb); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, f->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, f->c, APLOGNO(03047) "h2_from_h1(%d): err bucket status=%d", from_h1->stream_id, st); ap_die(st, r); @@ -528,7 +528,7 @@ apr_status_t h2_response_output_filter(ap_filter_t *f, apr_bucket_brigade *bb) from_h1->response = create_response(from_h1, r); if (from_h1->response == NULL) { - ap_log_cerror(APLOG_MARK, APLOG_NOTICE, 0, f->c, + ap_log_cerror(APLOG_MARK, APLOG_NOTICE, 0, f->c, APLOGNO(03048) "h2_from_h1(%d): unable to create response", from_h1->stream_id); return APR_ENOMEM; @@ -574,7 +574,7 @@ apr_status_t h2_response_trailers_filter(ap_filter_t *f, apr_bucket_brigade *bb) /* FIXME: need a better test case than this. apr_table_setn(r->trailers_out, "X", "1"); */ if (r->trailers_out && !apr_is_empty_table(r->trailers_out)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, f->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, f->c, APLOGNO(03049) "h2_from_h1(%d): trailers filter, saving trailers", from_h1->stream_id); h2_response_set_trailers(from_h1->response, diff --git a/modules/http2/h2_h2.c b/modules/http2/h2_h2.c index 6217c83e6f4..506fc9aa797 100644 --- a/modules/http2/h2_h2.c +++ b/modules/http2/h2_h2.c @@ -494,14 +494,14 @@ int h2_is_acceptable_connection(conn_rec *c, int require_all) if (strncmp("TLS", val, 3) || !strcmp("TLSv1", val) || !strcmp("TLSv1.1", val)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03050) "h2_h2(%ld): tls protocol not suitable: %s", (long)c->id, val); return 0; } } else if (require_all) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03051) "h2_h2(%ld): tls protocol is indetermined", (long)c->id); return 0; } @@ -512,14 +512,14 @@ int h2_is_acceptable_connection(conn_rec *c, int require_all) if (val && *val) { const char *source; if (cipher_is_blacklisted(val, &source)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03052) "h2_h2(%ld): tls cipher %s blacklisted by %s", (long)c->id, val, source); return 0; } } else if (require_all) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03053) "h2_h2(%ld): tls cipher is indetermined", (long)c->id); return 0; } @@ -617,7 +617,7 @@ int h2_h2_process_conn(conn_rec* c) AP_MODE_SPECULATIVE, APR_BLOCK_READ, 24); if (status != APR_SUCCESS) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, c, APLOGNO(03054) "h2_h2, error reading 24 bytes speculative"); apr_brigade_destroy(temp); return DECLINED; diff --git a/modules/http2/h2_io.c b/modules/http2/h2_io.c index 092a37c3912..5a20a7ed0a8 100644 --- a/modules/http2/h2_io.c +++ b/modules/http2/h2_io.c @@ -127,7 +127,7 @@ apr_status_t h2_io_signal_wait(h2_mplx *m, h2_io *io) if (io->timeout_at != 0) { status = apr_thread_cond_timedwait(io->timed_cond, m->lock, io->timeout_at); if (APR_STATUS_IS_TIMEUP(status)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, m->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, m->c, APLOGNO(03055) "h2_mplx(%ld-%d): stream timeout expired: %s", m->id, io->id, (io->timed_op == H2_IO_READ)? "read" : "write"); diff --git a/modules/http2/h2_mplx.c b/modules/http2/h2_mplx.c index 4fa0f591366..a9f305bf91e 100644 --- a/modules/http2/h2_mplx.c +++ b/modules/http2/h2_mplx.c @@ -307,7 +307,7 @@ apr_status_t h2_mplx_release_and_join(h2_mplx *m, apr_thread_cond_t *wait) } } } - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, m->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, m->c, APLOGNO(03056) "h2_mplx(%ld): release_join -> destroy", m->id); apr_thread_mutex_unlock(m->lock); h2_mplx_destroy(m); diff --git a/modules/http2/h2_push.c b/modules/http2/h2_push.c index 52f29f3d426..fa0154b564b 100644 --- a/modules/http2/h2_push.c +++ b/modules/http2/h2_push.c @@ -676,6 +676,7 @@ apr_array_header_t *h2_push_collect_update(h2_stream *stream, cache_digest, stream->pool); if (status != APR_SUCCESS) { ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, session->c, + APLOGNO(03057) "h2_session(%ld): push diary set from Cache-Digest: %s", session->id, cache_digest); } diff --git a/modules/http2/h2_request.c b/modules/http2/h2_request.c index 6fafa45f1a5..5ab958b26c9 100644 --- a/modules/http2/h2_request.c +++ b/modules/http2/h2_request.c @@ -167,7 +167,7 @@ apr_status_t h2_request_rwrite(h2_request *req, request_rec *r) status = add_all_h1_header(req, r->pool, r->headers_in); - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, status, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, status, r, APLOGNO(03058) "h2_request(%d): rwrite %s host=%s://%s%s", req->id, req->method, req->scheme, req->authority, req->path); @@ -313,13 +313,13 @@ apr_status_t h2_request_add_trailer(h2_request *req, apr_pool_t *pool, const char *value, size_t vlen) { if (!req->trailers) { - ap_log_perror(APLOG_MARK, APLOG_DEBUG, APR_EINVAL, pool, + ap_log_perror(APLOG_MARK, APLOG_DEBUG, APR_EINVAL, pool, APLOGNO(03059) "h2_request(%d): unanounced trailers", req->id); return APR_EINVAL; } if (nlen == 0 || name[0] == ':') { - ap_log_perror(APLOG_MARK, APLOG_DEBUG, APR_EINVAL, pool, + ap_log_perror(APLOG_MARK, APLOG_DEBUG, APR_EINVAL, pool, APLOGNO(03060) "h2_request(%d): pseudo header in trailer", req->id); return APR_EINVAL; diff --git a/modules/http2/h2_response.c b/modules/http2/h2_response.c index 3ef6f85063e..01bb20b9909 100644 --- a/modules/http2/h2_response.c +++ b/modules/http2/h2_response.c @@ -144,7 +144,8 @@ h2_response *h2_response_rcreate(int stream_id, request_rec *r, /* This request triggered a TLS renegotiation that is now allowed * in HTTP/2. Tell the client that it should use HTTP/1.1 for this. */ - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, response->http_status, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, response->http_status, r, + APLOGNO(03061) "h2_response(%ld-%d): renegotiate forbidden, cause: %s", (long)r->connection->id, stream_id, cause); response->rst_error = H2_ERR_HTTP_1_1_REQUIRED; diff --git a/modules/http2/h2_session.c b/modules/http2/h2_session.c index 34575a6b55a..1b527f4e789 100644 --- a/modules/http2/h2_session.c +++ b/modules/http2/h2_session.c @@ -199,7 +199,7 @@ static ssize_t send_cb(nghttp2_session *ngh2, if (APR_STATUS_IS_EAGAIN(status)) { return NGHTTP2_ERR_WOULDBLOCK; } - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, session->c, APLOGNO(03062) "h2_session: send error"); return h2_session_status_from_apr_status(status); } @@ -215,7 +215,7 @@ static int on_invalid_frame_recv_cb(nghttp2_session *ngh2, char buffer[256]; frame_print(frame, buffer, sizeof(buffer)/sizeof(buffer[0])); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03063) "h2_session(%ld): recv unknown FRAME[%s], frames=%ld/%ld (r/s)", session->id, buffer, (long)session->frames_received, (long)session->frames_sent); @@ -240,7 +240,7 @@ static int on_data_chunk_recv_cb(nghttp2_session *ngh2, uint8_t flags, stream = h2_session_get_stream(session, stream_id); if (!stream) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03064) "h2_stream(%ld-%d): on_data_chunk for unknown stream", session->id, (int)stream_id); rv = nghttp2_submit_rst_stream(ngh2, NGHTTP2_FLAG_NONE, stream_id, @@ -279,7 +279,7 @@ static apr_status_t stream_release(h2_session *session, } } else { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03065) "h2_stream(%ld-%d): closing with err=%d %s", session->id, (int)stream->id, (int)error_code, h2_h2_err_description(error_code)); @@ -376,7 +376,7 @@ static int on_frame_recv_cb(nghttp2_session *ng2s, char buffer[256]; frame_print(frame, buffer, sizeof(buffer)/sizeof(buffer[0])); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03066) "h2_session(%ld): recv FRAME[%s], frames=%ld/%ld (r/s)", session->id, buffer, (long)session->frames_received, (long)session->frames_sent); @@ -445,7 +445,7 @@ static int on_frame_recv_cb(nghttp2_session *ng2s, frame->window_update.window_size_increment); break; case NGHTTP2_RST_STREAM: - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03067) "h2_session(%ld-%d): RST_STREAM by client, errror=%d", session->id, (int)frame->hd.stream_id, (int)frame->rst_stream.error_code); @@ -606,7 +606,7 @@ static int on_frame_send_cb(nghttp2_session *ngh2, char buffer[256]; frame_print(frame, buffer, sizeof(buffer)/sizeof(buffer[0])); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03068) "h2_session(%ld): sent FRAME[%s], frames=%ld/%ld (r/s)", session->id, buffer, (long)session->frames_received, (long)session->frames_sent); @@ -702,7 +702,7 @@ static apr_status_t h2_session_shutdown(h2_session *session, int reason, const c reason, (uint8_t*)err, err? strlen(err):0); status = nghttp2_session_send(session->ngh2); h2_conn_io_flush(&session->io); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03069) "session(%ld): sent GOAWAY, err=%d, msg=%s", session->id, reason, err? err : ""); dispatch_event(session, H2_SESSION_EV_LOCAL_GOAWAY, reason, err); @@ -955,7 +955,7 @@ static apr_status_t h2_session_start(h2_session *session, int *rv) if (APLOGrdebug(session->r)) { char buffer[128]; h2_util_hex_dump(buffer, 128, (char*)cs, dlen); - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, session->r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, session->r, APLOGNO(03070) "upgrading h2c session with HTTP2-Settings: %s -> %s (%d)", s, buffer, (int)dlen); } @@ -1145,7 +1145,7 @@ static ssize_t stream_data_cb(nghttp2_session *ng2s, */ nread = 0; h2_stream_set_suspended(stream, 1); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03071) "h2_stream(%ld-%d): suspending", session->id, (int)stream_id); return NGHTTP2_ERR_DEFERRED; @@ -1170,7 +1170,7 @@ static ssize_t stream_data_cb(nghttp2_session *ng2s, int rv; nh = h2_util_ngheader_make(stream->pool, trailers); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03072) "h2_stream(%ld-%d): submit %d trailers", session->id, (int)stream_id,(int) nh->nvlen); rv = nghttp2_submit_trailer(ng2s, stream->id, nh->nv, nh->nvlen); @@ -1218,7 +1218,7 @@ static apr_status_t submit_response(h2_session *session, h2_stream *stream) provider.source.fd = stream->id; provider.read_callback = stream_data_cb; - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03073) "h2_stream(%ld-%d): submit response %d", session->id, stream->id, response->http_status); @@ -1258,7 +1258,7 @@ static apr_status_t submit_response(h2_session *session, h2_stream *stream) else { int err = H2_STREAM_RST(stream, H2_ERR_PROTOCOL_ERROR); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03074) "h2_stream(%ld-%d): RST_STREAM, err=%d", session->id, stream->id, err); @@ -1297,14 +1297,14 @@ struct h2_stream *h2_session_push(h2_session *session, h2_stream *is, nid = nghttp2_submit_push_promise(session->ngh2, 0, is->id, ngh->nv, ngh->nvlen, NULL); if (nid <= 0) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03075) "h2_stream(%ld-%d): submitting push promise fail: %s", session->id, is->id, nghttp2_strerror(nid)); return NULL; } ++session->pushes_promised; - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03076) "h2_stream(%ld-%d): SERVER_PUSH %d for %s %s on %d", session->id, is->id, nid, push->req->method, push->req->path, is->id); @@ -1323,7 +1323,7 @@ struct h2_stream *h2_session_push(h2_session *session, h2_stream *is, ++session->unsent_promises; } else { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03077) "h2_stream(%ld-%d): failed to create stream obj %d", session->id, is->id, nid); } @@ -1718,7 +1718,7 @@ static int is_accepting_streams(h2_session *session) static void transit(h2_session *session, const char *action, h2_session_state nstate) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03078) "h2_session(%ld): transit [%s] -- %s --> [%s]", session->id, state_name(session->state), action, state_name(nstate)); session->state = nstate; @@ -1974,6 +1974,7 @@ apr_status_t h2_session_process(h2_session *session, int async) ap_update_child_status(c->sbh, SERVER_BUSY_READ, NULL); status = h2_session_start(session, &rv); ap_log_cerror(APLOG_MARK, APLOG_DEBUG, status, c, + APLOGNO(03079) "h2_session(%ld): started on %s:%d", session->id, session->s->server_hostname, c->local_addr->port); @@ -2100,6 +2101,7 @@ apr_status_t h2_session_process(h2_session *session, int async) default: ap_log_cerror(APLOG_MARK, APLOG_ERR, APR_EGENERAL, c, + APLOGNO(03080) "h2_session(%ld): unknown state %d", session->id, session->state); dispatch_event(session, H2_SESSION_EV_PROTO_ERROR, 0, NULL); break; diff --git a/modules/http2/h2_stream.c b/modules/http2/h2_stream.c index 0a5af7eb3b8..fa1ebaeacd0 100644 --- a/modules/http2/h2_stream.c +++ b/modules/http2/h2_stream.c @@ -67,7 +67,7 @@ static int set_state(h2_stream *stream, h2_stream_state_t state) return 1; } - ap_log_cerror(APLOG_MARK, APLOG_WARNING, 0, stream->session->c, + ap_log_cerror(APLOG_MARK, APLOG_WARNING, 0, stream->session->c, APLOGNO(03081) "h2_stream(%ld-%d): invalid state transition from %d to %d", stream->session->id, stream->id, stream->state, state); return 0; @@ -160,7 +160,7 @@ h2_stream *h2_stream_open(int id, apr_pool_t *pool, h2_session *session) set_state(stream, H2_STREAM_ST_OPEN); stream->request = h2_request_create(id, pool, session->config); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, session->c, APLOGNO(03082) "h2_stream(%ld-%d): opened", session->id, stream->id); return stream; } diff --git a/modules/http2/h2_switch.c b/modules/http2/h2_switch.c index c08dd9e5fd1..d1d4a60f5de 100644 --- a/modules/http2/h2_switch.c +++ b/modules/http2/h2_switch.c @@ -58,13 +58,13 @@ static int h2_protocol_propose(conn_rec *c, request_rec *r, if (strcmp(AP_PROTOCOL_HTTP1, ap_get_protocol(c))) { /* We do not know how to switch from anything else but http/1.1. */ - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03083) "protocol switch: current proto != http/1.1, declined"); return DECLINED; } if (!h2_is_acceptable_connection(c, 0)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03084) "protocol propose: connection requirements not met"); return DECLINED; } @@ -82,14 +82,14 @@ static int h2_protocol_propose(conn_rec *c, request_rec *r, p = apr_table_get(r->headers_in, "HTTP2-Settings"); if (!p) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03085) "upgrade without HTTP2-Settings declined"); return DECLINED; } p = apr_table_get(r->headers_in, "Connection"); if (!ap_find_token(r->pool, p, "http2-settings")) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03086) "upgrade without HTTP2-Settings declined"); return DECLINED; } @@ -98,7 +98,7 @@ static int h2_protocol_propose(conn_rec *c, request_rec *r, */ p = apr_table_get(r->headers_in, "Content-Length"); if (p && strcmp(p, "0")) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03087) "upgrade with content-length: %s, declined", p); return DECLINED; } @@ -158,7 +158,7 @@ static int h2_protocol_switch(conn_rec *c, request_rec *r, server_rec *s, h2_ctx_server_set(ctx, r->server); status = h2_conn_setup(ctx, r->connection, r); if (status != APR_SUCCESS) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, status, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, status, r, APLOGNO(03088) "session setup"); return status; } diff --git a/modules/http2/mod_http2.c b/modules/http2/mod_http2.c index a44661c9233..41cde35f861 100644 --- a/modules/http2/mod_http2.c +++ b/modules/http2/mod_http2.c @@ -78,7 +78,7 @@ static int h2_post_config(apr_pool_t *p, apr_pool_t *plog, apr_pool_userdata_get(&data, mod_h2_init_key, s->process->pool); if ( data == NULL ) { - ap_log_error( APLOG_MARK, APLOG_DEBUG, 0, s, + ap_log_error( APLOG_MARK, APLOG_DEBUG, 0, s, APLOGNO(03089) "initializing post config dry run"); apr_pool_userdata_set((const void *)1, mod_h2_init_key, apr_pool_cleanup_null, s->process->pool); @@ -86,7 +86,7 @@ static int h2_post_config(apr_pool_t *p, apr_pool_t *plog, } ngh2 = nghttp2_version(0); - ap_log_error( APLOG_MARK, APLOG_INFO, 0, s, + ap_log_error( APLOG_MARK, APLOG_INFO, 0, s, APLOGNO(03090) "mod_http2 (v%s, nghttp2 %s), initializing...", MOD_HTTP2_VERSION, ngh2? ngh2->version_str : "unknown"); @@ -100,7 +100,7 @@ static int h2_post_config(apr_pool_t *p, apr_pool_t *plog, break; case H2_MPM_UNKNOWN: /* ??? */ - ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, APLOGNO(03091) "post_config: mpm type unknown"); break; } diff --git a/modules/loggers/mod_log_debug.c b/modules/loggers/mod_log_debug.c index 9111b119652..8a6c1244f5e 100644 --- a/modules/loggers/mod_log_debug.c +++ b/modules/loggers/mod_log_debug.c @@ -79,11 +79,15 @@ static void do_debug_log(request_rec *r, const char *hookname) ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(00641) "Can't evaluate message expression: %s", err); if (APLOGrdebug(r)) - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, "%s (%s hook, %s:%d)", + /* Intentional no APLOGNO */ + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + "%s (%s hook, %s:%d)", msg, hookname, entry->msg_expr->filename, entry->msg_expr->line_number); else - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, "%s", msg); + /* Intentional no APLOGNO */ + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + "%s", msg); } } diff --git a/modules/lua/lua_request.c b/modules/lua/lua_request.c index c59a3d082c1..f54c07b5eff 100644 --- a/modules/lua/lua_request.c +++ b/modules/lua/lua_request.c @@ -56,52 +56,53 @@ void ap_lua_rstack_dump(lua_State *L, request_rec *r, const char *msg) int t = lua_type(L, i); switch (t) { case LUA_TSTRING:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03001) "%d: '%s'", i, lua_tostring(L, i)); break; } case LUA_TUSERDATA:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, "%d: userdata", - i); + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03002) + "%d: userdata", i); break; } case LUA_TLIGHTUSERDATA:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03003) "%d: lightuserdata", i); break; } case LUA_TNIL:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, "%d: NIL", i); + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03004) + "%d: NIL", i); break; } case LUA_TNONE:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, "%d: None", i); + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03005) + "%d: None", i); break; } case LUA_TBOOLEAN:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, - "%d: %s", i, lua_toboolean(L, - i) ? "true" : - "false"); + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03006) + "%d: %s", i, + lua_toboolean(L, i) ? "true" : "false"); break; } case LUA_TNUMBER:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03007) "%d: %g", i, lua_tonumber(L, i)); break; } case LUA_TTABLE:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03008) "%d: ", i); break; } case LUA_TFUNCTION:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03009) "%d: ", i); break; } default:{ - ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(03010) "%d: unknown: -[%s]-", i, lua_typename(L, i)); break; } @@ -2147,8 +2148,8 @@ static int lua_websocket_greet(lua_State *L) request_rec *r = ap_lua_check_request_rec(L, 1); key = apr_table_get(r->headers_in, "Sec-WebSocket-Key"); if (key != NULL) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, - "Websocket: Got websocket key: %s", key); + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03011) + "Websocket: Got websocket key: %s", key); key = apr_pstrcat(r->pool, key, "258EAFA5-E914-47DA-95CA-C5AB0DC85B11", NULL); apr_sha1_init(&sha1); @@ -2170,7 +2171,7 @@ static int lua_websocket_greet(lua_State *L) r->bytes_sent = 0; r->read_chunked = 0; ap_rflush(r); - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03012) "Websocket: Upgraded from HTTP to Websocket"); lua_pushboolean(L, 1); return 1; @@ -2406,8 +2407,8 @@ static int lua_websocket_write(lua_State *L) string = lua_tolstring(L, 2, &len); if (raw != 1) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, - "Websocket: Writing framed message to client"); + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03013) + "Websocket: Writing framed message to client"); prelude = 0x81; /* text frame, FIN */ ap_rputc(prelude, r); @@ -2428,8 +2429,8 @@ static int lua_websocket_write(lua_State *L) } } else { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, - "Websocket: Writing raw message to client"); + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03014) + "Websocket: Writing raw message to client"); } ap_rwrite(string, len, r); rv = ap_rflush(r); @@ -2488,8 +2489,8 @@ static int lua_websocket_ping(lua_State *L) unsigned char mask = len >> 7; if (mask) len -= 128; plen = len; - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, - "Websocket: Got PONG opcode: %x", opcode); + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(03015) + "Websocket: Got PONG opcode: %x", opcode); if (opcode == 0x8A) { lua_pushboolean(L, 1); } @@ -2498,7 +2499,7 @@ static int lua_websocket_ping(lua_State *L) } if (plen > 0) { ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r, - "Websocket: Reading %" APR_SIZE_T_FMT " bytes of PONG", plen); + "Websocket: Reading %" APR_SIZE_T_FMT " bytes of PONG", plen); return 1; } if (mask) { diff --git a/modules/lua/mod_lua.c b/modules/lua/mod_lua.c index 2c69551cd57..ffe32ee3437 100644 --- a/modules/lua/mod_lua.c +++ b/modules/lua/mod_lua.c @@ -726,7 +726,8 @@ static int lua_request_rec_hook_harness(request_rec *r, const char *name, int ap hook_spec->file_name, hook_spec->function_name, name, rc); } else { - ap_log_rerror(APLOG_MARK, APLOG_CRIT, 0, r, "Lua hook %s:%s for phase %s did not return a numeric value", + ap_log_rerror(APLOG_MARK, APLOG_CRIT, 0, r, APLOGNO(03017) + "Lua hook %s:%s for phase %s did not return a numeric value", hook_spec->file_name, hook_spec->function_name, name); return HTTP_INTERNAL_SERVER_ERROR; } diff --git a/modules/proxy/mod_proxy.c b/modules/proxy/mod_proxy.c index afbb0748e8f..8b3576ed934 100644 --- a/modules/proxy/mod_proxy.c +++ b/modules/proxy/mod_proxy.c @@ -1826,23 +1826,23 @@ static const char * if (ap_proxy_is_ipaddr(New, parms->pool)) { #if DEBUGGING - ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, APLOGNO(03018) "Parsed addr %s", inet_ntoa(New->addr)); - ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, APLOGNO(03019) "Parsed mask %s", inet_ntoa(New->mask)); #endif } else if (ap_proxy_is_domainname(New, parms->pool)) { ap_str_tolower(New->name); #if DEBUGGING - ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, APLOGNO(03020) "Parsed domain %s", New->name); #endif } else if (ap_proxy_is_hostname(New, parms->pool)) { ap_str_tolower(New->name); #if DEBUGGING - ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, APLOGNO(03021) "Parsed host %s", New->name); #endif } diff --git a/modules/ssl/ssl_engine_init.c b/modules/ssl/ssl_engine_init.c index 8b26c353da3..d158795e6ee 100644 --- a/modules/ssl/ssl_engine_init.c +++ b/modules/ssl/ssl_engine_init.c @@ -1438,7 +1438,8 @@ static apr_status_t ssl_init_proxy_certs(server_rec *s, int j; for (j = 0; j < i; j++) { ssl_log_xerror(SSLLOG_MARK, APLOG_DEBUG, 0, ptemp, s, - sk_X509_value(chain, j), "%i:", j); + sk_X509_value(chain, j), APLOGNO(03039) + "%i:", j); } } } diff --git a/modules/ssl/ssl_util_stapling.c b/modules/ssl/ssl_util_stapling.c index 67caade31c4..779c3e3b635 100644 --- a/modules/ssl/ssl_util_stapling.c +++ b/modules/ssl/ssl_util_stapling.c @@ -797,7 +797,7 @@ static int stapling_cb(SSL *ssl, void *arg) stapling_refresh_mutex_off(s); if (rv == TRUE) { - ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, APLOGNO(03040) "stapling_cb: success renewing response"); } else { diff --git a/server/mpm/event/event.c b/server/mpm/event/event.c index cd70b7d904a..7346cc51732 100644 --- a/server/mpm/event/event.c +++ b/server/mpm/event/event.c @@ -860,7 +860,7 @@ static int start_lingering_close_common(event_conn_state_t *cs, int in_worker) rv = apr_pollset_add(event_pollset, &cs->pfd); apr_thread_mutex_unlock(timeout_mutex); if (rv != APR_SUCCESS && !APR_STATUS_IS_EEXIST(rv)) { - ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, APLOGNO(03092) "start_lingering_close: apr_pollset_add failure"); apr_thread_mutex_lock(timeout_mutex); TO_QUEUE_REMOVE(q, cs); @@ -1176,7 +1176,7 @@ read_request: apr_thread_mutex_unlock(timeout_mutex); if (rc != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ERR, rc, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ERR, rc, ap_server_conf, APLOGNO(03093) "process_socket: apr_pollset_add failure"); AP_DEBUG_ASSERT(rc == APR_SUCCESS); } @@ -1668,7 +1668,7 @@ static void * APR_THREAD_FUNC listener_thread(apr_thread_t * thd, void *dummy) */ if (rc != APR_SUCCESS && !APR_STATUS_IS_NOTFOUND(rc)) { ap_log_error(APLOG_MARK, APLOG_ERR, rc, ap_server_conf, - "pollset remove failed"); + APLOGNO(03094) "pollset remove failed"); start_lingering_close_nonblocking(cs); break; } @@ -1685,7 +1685,8 @@ static void * APR_THREAD_FUNC listener_thread(apr_thread_t * thd, void *dummy) rc = push2worker(out_pfd, event_pollset); if (rc != APR_SUCCESS) { ap_log_error(APLOG_MARK, APLOG_CRIT, rc, - ap_server_conf, "push2worker failed"); + ap_server_conf, APLOGNO(03095) + "push2worker failed"); } else { have_idle_worker = 0; @@ -1697,7 +1698,7 @@ static void * APR_THREAD_FUNC listener_thread(apr_thread_t * thd, void *dummy) break; default: ap_log_error(APLOG_MARK, APLOG_CRIT, rc, - ap_server_conf, + ap_server_conf, APLOGNO(03096) "event_loop: unexpected state %d", cs->pub.state); ap_assert(0); @@ -1749,7 +1750,7 @@ static void * APR_THREAD_FUNC listener_thread(apr_thread_t * thd, void *dummy) apr_allocator_owner_set(allocator, ptrans); if (ptrans == NULL) { ap_log_error(APLOG_MARK, APLOG_CRIT, rc, - ap_server_conf, + ap_server_conf, APLOGNO(03097) "Failed to create transaction pool"); signal_threads(ST_GRACEFUL); return NULL; @@ -1780,7 +1781,7 @@ static void * APR_THREAD_FUNC listener_thread(apr_thread_t * thd, void *dummy) */ apr_socket_close(csd); ap_log_error(APLOG_MARK, APLOG_CRIT, rc, - ap_server_conf, + ap_server_conf, APLOGNO(03098) "ap_queue_push failed"); ap_push_pool(worker_queue_info, ptrans); } @@ -1941,7 +1942,7 @@ static void *APR_THREAD_FUNC worker_thread(apr_thread_t * thd, void *dummy) /* We got some other error. */ else if (!workers_may_exit) { ap_log_error(APLOG_MARK, APLOG_CRIT, rv, ap_server_conf, - "ap_queue_pop failed"); + APLOGNO(03099) "ap_queue_pop failed"); } continue; } @@ -2032,7 +2033,7 @@ static void *APR_THREAD_FUNC start_threads(apr_thread_t * thd, void *dummy) worker_queue = apr_pcalloc(pchild, sizeof(*worker_queue)); rv = ap_queue_init(worker_queue, threads_per_child, pchild); if (rv != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, APLOGNO(03100) "ap_queue_init() failed"); clean_child_exit(APEXIT_CHILDFATAL); } @@ -2047,7 +2048,7 @@ static void *APR_THREAD_FUNC start_threads(apr_thread_t * thd, void *dummy) rv = ap_queue_info_create(&worker_queue_info, pchild, threads_per_child, max_recycled_pools); if (rv != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, APLOGNO(03101) "ap_queue_info_create() failed"); clean_child_exit(APEXIT_CHILDFATAL); } @@ -2058,7 +2059,7 @@ static void *APR_THREAD_FUNC start_threads(apr_thread_t * thd, void *dummy) rv = apr_thread_mutex_create(&timeout_mutex, APR_THREAD_MUTEX_DEFAULT, pchild); if (rv != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, APLOGNO(03102) "creation of the timeout mutex failed."); clean_child_exit(APEXIT_CHILDFATAL); } @@ -2085,7 +2086,7 @@ static void *APR_THREAD_FUNC start_threads(apr_thread_t * thd, void *dummy) pchild, APR_POLLSET_THREADSAFE | APR_POLLSET_NOCOPY); } if (rv != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, APLOGNO(03103) "apr_pollset_create with Thread Safety failed."); clean_child_exit(APEXIT_CHILDFATAL); } @@ -2121,6 +2122,7 @@ static void *APR_THREAD_FUNC start_threads(apr_thread_t * thd, void *dummy) worker_thread, my_info, pchild); if (rv != APR_SUCCESS) { ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, + APLOGNO(03104) "apr_thread_create: unable to create worker thread"); /* let the parent decide how bad this really is */ clean_child_exit(APEXIT_CHILDSICK); @@ -3245,7 +3247,7 @@ static int event_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00497) "WARNING: ServerLimit of %d exceeds compile-time " "limit of", server_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03105) " %d servers, decreasing to %d.", MAX_SERVER_LIMIT, MAX_SERVER_LIMIT); } else { @@ -3289,7 +3291,7 @@ static int event_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00502) "WARNING: ThreadLimit of %d exceeds compile-time " "limit of", thread_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03106) " %d threads, decreasing to %d.", MAX_THREAD_LIMIT, MAX_THREAD_LIMIT); } else { @@ -3333,10 +3335,10 @@ static int event_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00507) "WARNING: ThreadsPerChild of %d exceeds ThreadLimit " "of", threads_per_child); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03107) " %d threads, decreasing to %d.", thread_limit, thread_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03108) " To increase, please see the ThreadLimit " "directive."); } else { @@ -3365,11 +3367,11 @@ static int event_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00511) "WARNING: MaxRequestWorkers of %d is less than " "ThreadsPerChild of", max_workers); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03109) " %d, increasing to %d. MaxRequestWorkers must be at " "least as large", threads_per_child, threads_per_child); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03110) " as the number of threads in a single server."); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00512) @@ -3389,11 +3391,11 @@ static int event_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00513) "WARNING: MaxRequestWorkers of %d is not an integer " "multiple of", max_workers); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03111) " ThreadsPerChild of %d, decreasing to nearest " "multiple %d,", threads_per_child, tmp_max_workers); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03112) " for a maximum of %d servers.", ap_daemons_limit); } else { @@ -3411,10 +3413,10 @@ static int event_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00515) "WARNING: MaxRequestWorkers of %d would require %d " "servers and ", max_workers, ap_daemons_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03113) " would exceed ServerLimit of %d, decreasing to %d.", server_limit, server_limit * threads_per_child); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03114) " To increase, please see the ServerLimit " "directive."); } else { @@ -3446,9 +3448,9 @@ static int event_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00519) "WARNING: MinSpareThreads of %d not allowed, " "increasing to 1", min_spare_threads); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03115) " to avoid almost certain server failure."); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03116) " Please read the documentation."); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00520) diff --git a/server/mpm/mpmt_os2/mpmt_os2.c b/server/mpm/mpmt_os2/mpmt_os2.c index c1e122d7656..2380e2e5375 100644 --- a/server/mpm/mpmt_os2/mpmt_os2.c +++ b/server/mpm/mpmt_os2/mpmt_os2.c @@ -508,9 +508,9 @@ static int mpmt_os2_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00215) "WARNING: MinSpareThreads of %d not allowed, " "increasing to 1", ap_min_spare_threads); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03123) " to avoid almost certain server failure."); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03124) " Please read the documentation."); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00216) diff --git a/server/mpm/netware/mpm_netware.c b/server/mpm/netware/mpm_netware.c index 74f2ecc6745..d86ed23f6a0 100644 --- a/server/mpm/netware/mpm_netware.c +++ b/server/mpm/netware/mpm_netware.c @@ -1022,13 +1022,13 @@ static int netware_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00228) "WARNING: MaxThreads of %d exceeds compile-time " "limit of", ap_threads_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03125) " %d threads, decreasing to %d.", HARD_THREAD_LIMIT, HARD_THREAD_LIMIT); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03126) " To increase, please see the HARD_THREAD_LIMIT" "define in"); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03127) " server/mpm/netware%s.", MPM_HARD_LIMITS_FILE); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00229) @@ -1040,8 +1040,8 @@ static int netware_check_config(apr_pool_t *p, apr_pool_t *plog, } else if (ap_threads_limit < 1) { if (startup) { - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, - APLOGNO(00230) "WARNING: MaxThreads of %d not allowed, " + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00230) + "WARNING: MaxThreads of %d not allowed, " "increasing to 1.", ap_threads_limit); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(02661) @@ -1072,9 +1072,9 @@ static int netware_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00233) "WARNING: MinSpareThreads of %d not allowed, " "increasing to 1", ap_threads_min_free); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03128) " to avoid almost certain server failure."); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03129) " Please read the documentation."); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00234) diff --git a/server/mpm/prefork/prefork.c b/server/mpm/prefork/prefork.c index 9d424c545a1..19adec45a88 100644 --- a/server/mpm/prefork/prefork.c +++ b/server/mpm/prefork/prefork.c @@ -1412,7 +1412,7 @@ static int prefork_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00175) "WARNING: ServerLimit of %d exceeds compile-time " "limit of", server_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03130) " %d servers, decreasing to %d.", MAX_SERVER_LIMIT, MAX_SERVER_LIMIT); } else { @@ -1456,7 +1456,7 @@ static int prefork_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00180) "WARNING: MaxRequestWorkers of %d exceeds ServerLimit " "value of", ap_daemons_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03131) " %d servers, decreasing MaxRequestWorkers to %d.", server_limit, server_limit); ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, @@ -1502,9 +1502,9 @@ static int prefork_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00186) "WARNING: MinSpareServers of %d not allowed, " "increasing to 1", ap_daemons_min_free); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03132) " to avoid almost certain server failure."); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03133) " Please read the documentation."); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00187) diff --git a/server/mpm/winnt/mpm_winnt.c b/server/mpm/winnt/mpm_winnt.c index 853c38b8289..3d9ef15e5e7 100644 --- a/server/mpm/winnt/mpm_winnt.c +++ b/server/mpm/winnt/mpm_winnt.c @@ -1436,7 +1436,7 @@ static int winnt_check_config(apr_pool_t *pconf, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00439) "WARNING: ThreadLimit of %d exceeds compile-time " "limit of", thread_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03134) " %d threads, decreasing to %d.", MAX_THREAD_LIMIT, MAX_THREAD_LIMIT); } else if (is_parent) { @@ -1482,10 +1482,10 @@ static int winnt_check_config(apr_pool_t *pconf, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00444) "WARNING: ThreadsPerChild of %d exceeds ThreadLimit " "of", ap_threads_per_child); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03135) " %d threads, decreasing to %d.", thread_limit, thread_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03136) " To increase, please see the ThreadLimit " "directive."); } else if (is_parent) { diff --git a/server/mpm/worker/worker.c b/server/mpm/worker/worker.c index 4a729c0d35d..89f7ae11e4c 100644 --- a/server/mpm/worker/worker.c +++ b/server/mpm/worker/worker.c @@ -796,7 +796,7 @@ static void * APR_THREAD_FUNC listener_thread(apr_thread_t *thd, void * dummy) /* apr_pollset_poll() will only return errors in catastrophic * circumstances. Let's try exiting gracefully, for now. */ - ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ERR, rv, ap_server_conf, APLOGNO(03137) "apr_pollset_poll: (listen)"); signal_threads(ST_GRACEFUL); } @@ -866,7 +866,7 @@ static void * APR_THREAD_FUNC listener_thread(apr_thread_t *thd, void * dummy) * socket to a worker */ apr_socket_close(csd); - ap_log_error(APLOG_MARK, APLOG_CRIT, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_CRIT, rv, ap_server_conf, APLOGNO(03138) "ap_queue_push failed"); } else { @@ -979,7 +979,7 @@ worker_pop: } /* We got some other error. */ else if (!workers_may_exit) { - ap_log_error(APLOG_MARK, APLOG_CRIT, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_CRIT, rv, ap_server_conf, APLOGNO(03139) "ap_queue_pop failed"); } continue; @@ -1058,7 +1058,7 @@ static void * APR_THREAD_FUNC start_threads(apr_thread_t *thd, void *dummy) worker_queue = apr_pcalloc(pchild, sizeof(*worker_queue)); rv = ap_queue_init(worker_queue, threads_per_child, pchild); if (rv != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, APLOGNO(03140) "ap_queue_init() failed"); clean_child_exit(APEXIT_CHILDFATAL); } @@ -1066,7 +1066,7 @@ static void * APR_THREAD_FUNC start_threads(apr_thread_t *thd, void *dummy) rv = ap_queue_info_create(&worker_queue_info, pchild, threads_per_child); if (rv != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, + ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, APLOGNO(03141) "ap_queue_info_create() failed"); clean_child_exit(APEXIT_CHILDFATAL); } @@ -1098,8 +1098,8 @@ static void * APR_THREAD_FUNC start_threads(apr_thread_t *thd, void *dummy) rv = apr_thread_create(&threads[i], thread_attr, worker_thread, my_info, pchild); if (rv != APR_SUCCESS) { - ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, - "apr_thread_create: unable to create worker thread"); + ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf, APLOGNO(03142) + "apr_thread_create: unable to create worker thread"); /* let the parent decide how bad this really is */ clean_child_exit(APEXIT_CHILDSICK); } @@ -2179,7 +2179,7 @@ static int worker_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00300) "WARNING: ServerLimit of %d exceeds compile-time " "limit of", server_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03143) " %d servers, decreasing to %d.", MAX_SERVER_LIMIT, MAX_SERVER_LIMIT); } else { @@ -2223,7 +2223,7 @@ static int worker_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00305) "WARNING: ThreadLimit of %d exceeds compile-time " "limit of", thread_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03144) " %d threads, decreasing to %d.", MAX_THREAD_LIMIT, MAX_THREAD_LIMIT); } else { @@ -2267,10 +2267,10 @@ static int worker_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00310) "WARNING: ThreadsPerChild of %d exceeds ThreadLimit " "of", threads_per_child); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03145) " %d threads, decreasing to %d.", thread_limit, thread_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03146) " To increase, please see the ThreadLimit " "directive."); } else { @@ -2299,11 +2299,11 @@ static int worker_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00314) "WARNING: MaxRequestWorkers of %d is less than " "ThreadsPerChild of", max_workers); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03147) " %d, increasing to %d. MaxRequestWorkers must be at " "least as large", threads_per_child, threads_per_child); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03148) " as the number of threads in a single server."); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00315) @@ -2323,11 +2323,11 @@ static int worker_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00316) "WARNING: MaxRequestWorkers of %d is not an integer " "multiple of", max_workers); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03149) " ThreadsPerChild of %d, decreasing to nearest " "multiple %d,", threads_per_child, tmp_max_workers); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03150) " for a maximum of %d servers.", ap_daemons_limit); } else { @@ -2345,7 +2345,7 @@ static int worker_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00318) "WARNING: MaxRequestWorkers of %d would require %d " "servers and ", max_workers, ap_daemons_limit); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03151) " would exceed ServerLimit of %d, decreasing to %d.", server_limit, server_limit * threads_per_child); ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, @@ -2380,9 +2380,9 @@ static int worker_check_config(apr_pool_t *p, apr_pool_t *plog, ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(00322) "WARNING: MinSpareThreads of %d not allowed, " "increasing to 1", min_spare_threads); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03152) " to avoid almost certain server failure."); - ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, + ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, APLOGNO(03153) " Please read the documentation."); } else { ap_log_error(APLOG_MARK, APLOG_WARNING, 0, s, APLOGNO(00323) diff --git a/server/protocol.c b/server/protocol.c index 7fc5b096630..86f2f5e7184 100644 --- a/server/protocol.c +++ b/server/protocol.c @@ -1885,7 +1885,7 @@ AP_DECLARE(const char *) ap_select_protocol(conn_rec *c, request_rec *r, if (APLOGcdebug(c)) { const char *p = apr_array_pstrcat(pool, conf->protocols, ','); - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03155) "select protocol from %s, choices=%s for server %s", p, apr_array_pstrcat(pool, choices, ','), s->server_hostname); @@ -1929,7 +1929,7 @@ AP_DECLARE(const char *) ap_select_protocol(conn_rec *c, request_rec *r, /* Select the most preferred protocol */ if (APLOGcdebug(c)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03156) "select protocol, proposals=%s preferences=%s configured=%s", apr_array_pstrcat(pool, proposals, ','), apr_array_pstrcat(pool, prefs, ','), @@ -1949,7 +1949,8 @@ AP_DECLARE(const char *) ap_select_protocol(conn_rec *c, request_rec *r, } } if (APLOGcdebug(c)) { - ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, "selected protocol=%s", + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(03157) + "selected protocol=%s", protocol? protocol : "(none)"); } diff --git a/server/util_filter.c b/server/util_filter.c index 01eb5335204..51e24f67e8e 100644 --- a/server/util_filter.c +++ b/server/util_filter.c @@ -618,7 +618,8 @@ AP_DECLARE(apr_status_t) ap_pass_brigade_fchk(request_rec *r, va_start(ap, fmt); res = apr_pvsprintf(r->pool, fmt, ap); va_end(ap); - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r, "%s", res); + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r, APLOGNO(03158) + "%s", res); } return HTTP_INTERNAL_SERVER_ERROR; }