From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 10 Jun 2015 16:18:22 +0000 (-0400)
Subject: rad_getgid() returns <0 on error
X-Git-Tag: release_3_0_9~209
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=adf1681e9799c916e5f5b122ecc1ad56df5bacd4;p=thirdparty%2Ffreeradius-server.git

rad_getgid() returns <0 on error
---

diff --git a/src/modules/rlm_opendirectory/rlm_opendirectory.c b/src/modules/rlm_opendirectory/rlm_opendirectory.c
index d76120d3dcf..5b6418d1c92 100644
--- a/src/modules/rlm_opendirectory/rlm_opendirectory.c
+++ b/src/modules/rlm_opendirectory/rlm_opendirectory.c
@@ -361,15 +361,14 @@ static rlm_rcode_t CC_HINT(nonnull) mod_authorize(UNUSED void *instance, REQUEST
 	uuid_clear(guid_sacl);
 
 	if (rad_getgid(request, &gid, kRadiusSACLName) < 0) {
+		RDEBUG("The SACL group \"%s\" does not exist on this system.", kRadiusSACLName);
+	} else {
 		err = mbr_gid_to_uuid(gid, guid_sacl);
 		if (err != 0) {
 			ERROR("rlm_opendirectory: The group \"%s\" does not have a GUID.", kRadiusSACLName);
 			return RLM_MODULE_FAIL;
 		}
 	}
-	else {
-		RDEBUG("The SACL group \"%s\" does not exist on this system.", kRadiusSACLName);
-	}
 
 	/* resolve client access list */
 	uuid_clear(guid_nasgroup);