From: Christophe Jaillet <jailletc36@apache.org>
Date: Tue, 17 Apr 2018 19:33:27 +0000 (+0000)
Subject: Explain when the surrounding double quotes arround the expr argument MUST be avoided.
X-Git-Tag: 2.5.0-alpha2-ci-test-only~2679
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=adf6ef9e625f44d4a302a94f2b74c6dd090412a9;p=thirdparty%2Fapache%2Fhttpd.git

Explain when the surrounding double quotes arround the expr argument MUST be avoided.

Fix an example to add these surrounding quotes to be consistent and in line with 2.4.x

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1829390 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/docs/manual/mod/mod_authz_core.xml b/docs/manual/mod/mod_authz_core.xml
index 40bcc250585..27e71486043 100644
--- a/docs/manual/mod/mod_authz_core.xml
+++ b/docs/manual/mod/mod_authz_core.xml
@@ -180,7 +180,7 @@ SetEnvIf User-Agent "^KnockKnock/2\.0" let_me_in
   decisions on arbitrary expressions.</p>
 
     <highlight language="config">
-        Require expr %{TIME_HOUR} -ge 9 &amp;&amp; %{TIME_HOUR} -le 17
+        Require expr "%{TIME_HOUR} -ge 9 &amp;&amp; %{TIME_HOUR} -le 17"
     </highlight>
 
     <highlight language="config">
@@ -195,7 +195,8 @@ SetEnvIf User-Agent "^KnockKnock/2\.0" let_me_in
     </highlight>
 
   <p>The syntax is described in the <a href="../expr.html">ap_expr</a>
-  documentation.</p>
+  documentation. Before httpd 2.4.16, the surrounding double-quotes MUST be
+  omitted.</p>
 
   <p>Normally, the expression is evaluated before authentication. However, if
   the expression returns false and references the variable