From: Marcin Siodelski <marcin@isc.org>
Date: Thu, 10 Dec 2020 08:11:20 +0000 (+0100)
Subject: [#1250] Fixed sporadic UT failures
X-Git-Tag: Kea-1.9.3~61
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=adfa4eab2f8f3f57bea33ad88e3f09c161356df3;p=thirdparty%2Fkea.git

[#1250] Fixed sporadic UT failures

The tests were performing strict cltt comparison now the comparison is
not strict to avoid acceptable off by 1 errors.
---

diff --git a/src/bin/dhcp6/tests/rebind_unittest.cc b/src/bin/dhcp6/tests/rebind_unittest.cc
index 8fa183040d..a9d59dc3e0 100644
--- a/src/bin/dhcp6/tests/rebind_unittest.cc
+++ b/src/bin/dhcp6/tests/rebind_unittest.cc
@@ -945,7 +945,7 @@ TEST_F(RebindTest, requestPrefixInRebind) {
     EXPECT_EQ(STATUS_Success, client.getStatusCode(1234));
 
     // The lease should have been rebound.
-    EXPECT_EQ(1000, leases_client_na_rebound[0].cltt_ - leases_client_na[0].cltt_);
+    EXPECT_GE(leases_client_na_rebound[0].cltt_ - leases_client_na[0].cltt_, 1000);
 
     // The client should now also acquire a PD lease.
     leases_client_pd = client.getLeasesByType(Lease::TYPE_PD);
diff --git a/src/bin/dhcp6/tests/renew_unittest.cc b/src/bin/dhcp6/tests/renew_unittest.cc
index 50d92cc20c..f8d2c32d06 100644
--- a/src/bin/dhcp6/tests/renew_unittest.cc
+++ b/src/bin/dhcp6/tests/renew_unittest.cc
@@ -376,8 +376,8 @@ TEST_F(RenewTest, renewWithExcludedPrefix) {
     EXPECT_EQ(STATUS_Success, client.getStatusCode(pd_iaid_));
 
     // The leases should have been renewed.
-    EXPECT_EQ(1000, leases_client_na_renewed[0].cltt_ - leases_client_na[0].cltt_);
-    EXPECT_EQ(1000, leases_client_pd_renewed[0].cltt_ - leases_client_pd[0].cltt_);
+    EXPECT_GE(leases_client_na_renewed[0].cltt_ - leases_client_na[0].cltt_, 1000);
+    EXPECT_GE(leases_client_pd_renewed[0].cltt_ - leases_client_pd[0].cltt_, 1000);
 
     // This time, the Prefix Exclude option should be included.
     option = client.getContext().response_->getOption(D6O_IA_PD);