From: Alan T. DeKok <aland@freeradius.org>
Date: Sat, 11 May 2024 00:16:25 +0000 (-0400)
Subject: try to satisfy clang scan, too
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae174ae97d3274cb168a87e445348845b1da07a2;p=thirdparty%2Ffreeradius-server.git

try to satisfy clang scan, too
---

diff --git a/src/lib/server/module.c b/src/lib/server/module.c
index 3b1a5a8a385..4182f8650a6 100644
--- a/src/lib/server/module.c
+++ b/src/lib/server/module.c
@@ -421,7 +421,7 @@ static void mlg_data_del(module_instance_t *mi)
 	mlg_module_instance_t	*mlg_mi = (mlg_module_instance_t *)talloc_get_type_abort(mi, module_instance_t);
 
 	if (!fr_heap_entry_inserted(mlg_mi->inst_idx)) return;
-	
+
 	if (fr_heap_extract(&mlg_index, mi) == 0) return;
 
 	fr_assert(0);
@@ -683,6 +683,11 @@ static int8_t module_instance_name_cmp(void const *one, void const *two)
 	int a_depth = 0, b_depth = 0;
 	int ret;
 
+#ifdef STATIC_ANALYZER
+	if (!fr_cond_assert(a)) return +1;
+	if (!fr_cond_assert(b)) return -1;
+#endif
+
 	/*
 	 *	Sort by depth, so for tree walking we start
 	 *	at the shallowest node, and finish with