From: Laine Stump <laine@laine.org>
Date: Mon, 19 Jul 2010 23:52:57 +0000 (-0400)
Subject: Remove erroneous setting of return value to errno.
X-Git-Tag: v0.8.3~94
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae3d31bf4f3ada5cfbe43891a133e8697755bb99;p=thirdparty%2Flibvirt.git

Remove erroneous setting of return value to errno.

One error exit in virStorageBackendCreateBlockFrom was setting the
return value to errno. The convention for volume build functions is to
return 0 on success or -1 on failure. Not only was it not necessary to
set the return value (it defaults to -1, and is set to 0 when
everything has been successfully completed), in the case that some
caller were checking for < 0 rather than != 0, they would incorrectly
believe that it completed successfully.
---

diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
index 5b61bba3ba..d9897434d5 100644
--- a/src/storage/storage_backend.c
+++ b/src/storage/storage_backend.c
@@ -232,7 +232,6 @@ virStorageBackendCreateBlockFrom(virConnectPtr conn ATTRIBUTE_UNUSED,
     }
 
     if (fstat(fd, &st) == -1) {
-        ret = errno;
         virReportSystemError(errno, _("stat of '%s' failed"),
                              vol->target.path);
         goto cleanup;