From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Date: Fri, 27 Jun 2025 18:13:41 +0000 (+0000)
Subject: apps/lib/log.c: Add check for BIO_new()
X-Git-Tag: 4.0-PRE-CLANG-FORMAT-WEBKIT~115
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae4d37e3fb0fc772c3eb22878c0206345dec8286;p=thirdparty%2Fopenssl.git

apps/lib/log.c: Add check for BIO_new()

Add check for the return value of BIO_new() to avoid potential NULL pointer dereference.

Fixes: 8a2ec00d7f ("apps/lib/http_server.{c,h}: clean up logging and move it to log.{c,h}")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>

Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27918)
---

diff --git a/apps/lib/log.c b/apps/lib/log.c
index a5e2f5507af..cfe5973960e 100644
--- a/apps/lib/log.c
+++ b/apps/lib/log.c
@@ -46,6 +46,9 @@ static void log_with_prefix(const char *prog, const char *fmt, va_list ap)
     char prefix[80];
     BIO *bio, *pre = BIO_new(BIO_f_prefix());
 
+    if (pre == NULL)
+        return;
+
     (void)BIO_snprintf(prefix, sizeof(prefix), "%s: ", prog);
     (void)BIO_set_prefix(pre, prefix);
     bio = BIO_push(pre, bio_err);