From: Andreas Schneider <asn@samba.org>
Date: Thu, 7 Aug 2025 11:48:04 +0000 (+0200)
Subject: auth:creds: Keep password secret in cmdline_get_userpassword()
X-Git-Tag: samba-4.23.0rc3~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae5124ac5f52a344822194c2e50fe614c408a367;p=thirdparty%2Fsamba.git

auth:creds: Keep password secret in cmdline_get_userpassword()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15893

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
(cherry picked from commit 34482f4ad014a09c84b484097a8d03dfec4f6512)
---

diff --git a/auth/credentials/credentials_cmdline.c b/auth/credentials/credentials_cmdline.c
index c8c7c183c22..e9cdc80d52a 100644
--- a/auth/credentials/credentials_cmdline.c
+++ b/auth/credentials/credentials_cmdline.c
@@ -46,6 +46,7 @@ static const char *cmdline_get_userpassword(struct cli_credentials *creds)
 		goto fail;
 	}
 	talloc_set_name_const(ret, __location__);
+	talloc_keep_secret(ret);
 fail:
 	ZERO_STRUCT(pwd);
 	TALLOC_FREE(frame);