From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 1 Jul 2025 12:15:28 +0000 (+0200)
Subject: auth: Use arc4random(void *, size) in TSIG generation
X-Git-Tag: rec-5.3.0-alpha2~15^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae55fc4c591f3c49d3938ed274e96e2b0027f8a0;p=thirdparty%2Fpdns.git

auth: Use arc4random(void *, size) in TSIG generation

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/tsigutils.cc b/pdns/tsigutils.cc
index e81386bd8f..08378abac8 100644
--- a/pdns/tsigutils.cc
+++ b/pdns/tsigutils.cc
@@ -50,10 +50,6 @@ std::string makeTSIGKey(const DNSName& algorithm) {
   tmpkey.resize(klen);
 
   // Fill out the key
-  for (size_t i = 0; i < klen; i += sizeof(uint32_t)) {
-    uint32_t t = dns_random_uint32();
-    memcpy(&tmpkey.at(i), &t, sizeof(uint32_t));
-  }
-
+  dns_random(tmpkey.data(), klen);
   return Base64Encode(tmpkey);
 }