From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Tue, 2 May 2023 11:09:15 +0000 (+0200)
Subject: move transaction opening outside of both if branches
X-Git-Tag: auth-4.8.0-beta1~1^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae6198721035b5f4eb61f77391a8bf092b24cca2;p=thirdparty%2Fpdns.git

move transaction opening outside of both if branches
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index ec425cc187..88cde13a1e 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1661,9 +1661,8 @@ bool LMDBBackend::createDomain(const DNSName& domain, const DomainInfo::DomainKi
 
 void LMDBBackend::getAllDomainsFiltered(vector<DomainInfo>* domains, const std::function<bool(DomainInfo&)>& allow)
 {
+  auto txn = d_tdomains->getROTransaction();
   if (d_handle_dups) {
-    auto txn = d_tdomains->getROTransaction();
-
     map<DNSName, DomainInfo> zonemap;
     set<DNSName> dups;
 
@@ -1695,7 +1694,6 @@ void LMDBBackend::getAllDomainsFiltered(vector<DomainInfo>* domains, const std::
     }
   }
   else {
-    auto txn = d_tdomains->getROTransaction();
     for (auto iter = txn.begin(); iter != txn.end(); ++iter) {
       DomainInfo di = *iter;
       di.id = iter.getID();