From: Tony Battersby <tonyb@cybernetics.com>
Date: Thu, 23 Oct 2014 19:10:21 +0000 (-0400)
Subject: lib/scatterlist: fix memory leak with scsi-mq
X-Git-Tag: v3.18-rc3~2^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae674792c32bc54832e52706ec669d59cbea7ab6;p=thirdparty%2Fkernel%2Flinux.git

lib/scatterlist: fix memory leak with scsi-mq

Fix a memory leak with scsi-mq triggered by commands with large data
transfer length.

Fixes: c53c6d6a68b1 ("scatterlist: allow chaining to preallocated chunks")
Cc: <stable@vger.kernel.org> # 3.17.x
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index 9cdf62f8accde..c9f2e8c6ccc99 100644
--- a/lib/scatterlist.c
+++ b/lib/scatterlist.c
@@ -203,10 +203,10 @@ void __sg_free_table(struct sg_table *table, unsigned int max_ents,
 		}
 
 		table->orig_nents -= sg_size;
-		if (!skip_first_chunk) {
-			free_fn(sgl, alloc_size);
+		if (skip_first_chunk)
 			skip_first_chunk = false;
-		}
+		else
+			free_fn(sgl, alloc_size);
 		sgl = next;
 	}