From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Tue, 11 Jan 2022 14:46:19 +0000 (-0500)
Subject: remove non-working mssql description_encoding param
X-Git-Tag: rel_2_0_0b1~549
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ae718bbe797f8c06f8ef88a993af7e14007f1834;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

remove non-working mssql description_encoding param

the description_encoding concept has been fully
removed in 2.0, but this logic was plainly broken
in any case.   The same non-working logic exists in
1.4 as well, where description_encoding as a concept
is not removed, though it is likely that there are no
real-world use cases for it.

Change-Id: Icaf47f4740e3f57063b614a1d4136e0d89f40621
---

diff --git a/lib/sqlalchemy/dialects/mssql/pyodbc.py b/lib/sqlalchemy/dialects/mssql/pyodbc.py
index b629aadd32..3af083a6ae 100644
--- a/lib/sqlalchemy/dialects/mssql/pyodbc.py
+++ b/lib/sqlalchemy/dialects/mssql/pyodbc.py
@@ -512,11 +512,7 @@ class MSDialect_pyodbc(PyODBCConnector, MSDialect):
         },
     )
 
-    def __init__(
-        self, description_encoding=None, fast_executemany=False, **params
-    ):
-        if "description_encoding" in params:
-            self.description_encoding = params.pop("description_encoding")
+    def __init__(self, fast_executemany=False, **params):
         super(MSDialect_pyodbc, self).__init__(**params)
         self.use_scope_identity = (
             self.use_scope_identity