From: Karel Zak <kzak@redhat.com>
Date: Thu, 17 Jul 2014 13:00:17 +0000 (+0200)
Subject: findmnt: fix memory leak [coverity scan]
X-Git-Tag: v2.25~37
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aea3a3ba2ccaa11e66d50f4b4658e33d6675715a;p=thirdparty%2Futil-linux.git

findmnt: fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/misc-utils/findmnt.c b/misc-utils/findmnt.c
index 847c349a2c..c710cbb005 100644
--- a/misc-utils/findmnt.c
+++ b/misc-utils/findmnt.c
@@ -711,16 +711,21 @@ static int has_line(struct libscols_table *table, struct libmnt_fs *fs)
 {
 	struct libscols_line *ln;
 	struct libscols_iter *itr;
+	int rc = 0;
 
 	itr = scols_new_iter(SCOLS_ITER_FORWARD);
 	if (!itr)
 		return 0;
 
-	while(scols_table_next_line(table, itr, &ln) == 0) {
-		if ((struct libmnt_fs *) scols_line_get_userdata(ln) == fs)
-			return 1;
+	while (scols_table_next_line(table, itr, &ln) == 0) {
+		if ((struct libmnt_fs *) scols_line_get_userdata(ln) == fs) {
+			rc = 1;
+			break;
+		}
 	}
-	return 0;
+
+	scols_free_iter(itr);
+	return rc;
 }
 
 /* reads filesystems from @tb (libmount) and fillin @table (output table) */