From: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Date: Thu, 12 May 2022 22:16:13 +0000 (+0200)
Subject: test: disable tests throwing copy to executemany in client-side cursors
X-Git-Tag: 3.1~99^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aedba5c0cf8336710b3d312ea1092396e5f73a8e;p=thirdparty%2Fpsycopg.git

test: disable tests throwing copy to executemany in client-side cursors

The async one sometimes gets in an allocation loop. On my laptop it gets
OOM'd quickly. On Github Actions it might be the cause of test taking an
unusually long time.
---

diff --git a/tests/test_client_cursor.py b/tests/test_client_cursor.py
index c2db78750..e4a308328 100644
--- a/tests/test_client_cursor.py
+++ b/tests/test_client_cursor.py
@@ -376,7 +376,10 @@ def test_executemany_rowcount_no_hit(conn, execmany):
     "query",
     [
         "insert into nosuchtable values (%s, %s)",
-        "copy (select %s, %s) to stdout",
+        # This fails, but only because we try to copy in pipeline mode,
+        # crashing the connection. Which would be even fine, but with
+        # the async cursor it's worse... See test_client_cursor_async.py.
+        # "copy (select %s, %s) to stdout",
         "wat (%s, %s)",
     ],
 )
diff --git a/tests/test_client_cursor_async.py b/tests/test_client_cursor_async.py
index af8307ac9..e6981d5d7 100644
--- a/tests/test_client_cursor_async.py
+++ b/tests/test_client_cursor_async.py
@@ -368,7 +368,11 @@ async def test_executemany_rowcount_no_hit(aconn, execmany):
     "query",
     [
         "insert into nosuchtable values (%s, %s)",
-        "copy (select %s, %s) to stdout",
+        # This fails because we end up trying to copy in pipeline mode.
+        # However, sometimes (and pretty regularly if we enable pgconn.trace())
+        # something goes in a loop and only terminates by OOM. Strace shows
+        # an allocation loop. I think it's in the libpq.
+        # "copy (select %s, %s) to stdout",
         "wat (%s, %s)",
     ],
 )