From: Jukka Kurkela <jukka.kurkela@gmail.com>
Date: Sat, 13 Mar 2021 13:04:59 +0000 (+0200)
Subject: Types: fix bubble chart options (#8625)
X-Git-Tag: v3.0.0-beta.14~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aee979da540fbfb2329397def4c746a5f9a549ff;p=thirdparty%2FChart.js.git

Types: fix bubble chart options (#8625)
---

diff --git a/test/types/simple.ts b/test/types/simple.ts
deleted file mode 100644
index 214dd07c0..000000000
--- a/test/types/simple.ts
+++ /dev/null
@@ -1,25 +0,0 @@
-import {Chart, IBarControllerConfiguration} from '../..';
-
-const bar = new Chart(document.createElement('canvas'), {
-    type: 'bar',
-    data: {
-        labels: ['A', 'B'],
-        datasets: [
-            {
-                data: [1,2],
-            }
-        ]
-    }
-});
-
-const barTyped = new Chart<number, string, IBarControllerConfiguration<number, string>>(document.createElement('canvas'), {
-    type: 'bar',
-    data: {
-        labels: ['A', 'B'],
-        datasets: [
-            {
-                data: [1,2],
-            }
-        ]
-    }
-});
\ No newline at end of file
diff --git a/types/index.esm.d.ts b/types/index.esm.d.ts
index f72cd8ae3..c19471055 100644
--- a/types/index.esm.d.ts
+++ b/types/index.esm.d.ts
@@ -3184,7 +3184,7 @@ export interface ChartTypeRegistry {
     scales: keyof CartesianScaleTypeRegistry;
   };
   bubble: {
-    chartOptions: EmptyObject;
+    chartOptions: unknown;
     datasetOptions: BubbleControllerDatasetOptions;
     defaultDataPoint: BubbleDataPoint;
     parsedDataType: BubbleParsedData;
@@ -3268,7 +3268,7 @@ export interface ChartData<
   TData = DefaultDataPoint<TType>,
   TLabel = unknown
 > {
-  labels: TLabel[];
+  labels?: TLabel[];
   datasets: ChartDataset<TType, TData>[];
 }
 
diff --git a/types/tests/controllers/bubble_chart_options.ts b/types/tests/controllers/bubble_chart_options.ts
new file mode 100644
index 000000000..e036037e6
--- /dev/null
+++ b/types/tests/controllers/bubble_chart_options.ts
@@ -0,0 +1,22 @@
+import { Chart, ChartOptions } from '../../index.esm';
+
+const chart = new Chart('test', {
+  type: 'bubble',
+  data: {
+    datasets: []
+  },
+  options: {
+    scales: {
+      x: {
+        min: 0,
+        max: 30,
+        ticks: {}
+      },
+      y: {
+        min: 0,
+        max: 30,
+        ticks: {},
+      },
+    }
+  }
+});