From: Mike Bayer Date: Sat, 29 May 2021 15:05:25 +0000 (-0400) Subject: skip dupe order by test on mssql X-Git-Tag: rel_1_4_17~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aeee452eb03430e189480392a54c6278e6029a7d;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git skip dupe order by test on mssql SQL Server wants to complain if ORDER BY specifies the same expression more than once, so just skip this test added in aaba0650d7410f579b2c14f8f1b0680a1d1852c4 as this only needs to test ORM functionality. Change-Id: I857746771ed9c661043d7a8661efe9f47449c466 --- diff --git a/test/orm/test_dynamic.py b/test/orm/test_dynamic.py index 68547b1539..b4ab4047d5 100644 --- a/test/orm/test_dynamic.py +++ b/test/orm/test_dynamic.py @@ -343,6 +343,7 @@ class DynamicTest(_DynamicFixture, _fixtures.FixtureTest, AssertsCompiledSQL): ], ) + @testing.requires.dupe_order_by_ok def test_order_by_composition_uses_immutable_tuple(self): addresses = self.tables.addresses User, Address = self._user_address_fixture( diff --git a/test/requirements.py b/test/requirements.py index 6628d9ef38..86ae3d4b5b 100644 --- a/test/requirements.py +++ b/test/requirements.py @@ -705,6 +705,15 @@ class DefaultRequirements(SuiteRequirements): "no support for EXCEPT", ) + @property + def dupe_order_by_ok(self): + """target db wont choke if ORDER BY specifies the same expression + more than once + + """ + + return skip_if("mssql") + @property def order_by_col_from_union(self): """target database supports ordering by a column from a SELECT