From: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Date: Fri, 24 Jan 2025 00:18:00 +0000 (+1300)
Subject: s4:dsdb: Check dsdb_module_search() return value
X-Git-Tag: tevent-0.17.0~108
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aef850833377b910ba2a67446dbbb96a4d86ab46;p=thirdparty%2Fsamba.git

s4:dsdb: Check dsdb_module_search() return value

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/source4/dsdb/samdb/ldb_modules/acl.c b/source4/dsdb/samdb/ldb_modules/acl.c
index 3e5588c95bb..d0b1216bcc1 100644
--- a/source4/dsdb/samdb/ldb_modules/acl.c
+++ b/source4/dsdb/samdb/ldb_modules/acl.c
@@ -777,6 +777,10 @@ static int acl_check_spn(TALLOC_CTX *mem_ctx,
 				 req,
 				 "(ncName=%s)",
 				 ldb_dn_get_linearized(ldb_get_default_basedn(ldb)));
+	if (ret != LDB_SUCCESS) {
+		talloc_free(tmp_ctx);
+		return ret;
+	}
 
 	netbios_name = ldb_msg_find_attr_as_string(netbios_res->msgs[0], "nETBIOSName", NULL);