From: Volker Lendecke <vl@samba.org>
Date: Wed, 23 Aug 2023 11:25:37 +0000 (+0200)
Subject: libsmb: Remove two #defines just used once
X-Git-Tag: tevent-0.16.0~502
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aef98c6356b351f0fa8b7f1612384df865b4547f;p=thirdparty%2Fsamba.git

libsmb: Remove two #defines just used once

To me these two did not create clarity.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/include/libsmb_internal.h b/source3/include/libsmb_internal.h
index b695995dbcc..e30bfeb6690 100644
--- a/source3/include/libsmb_internal.h
+++ b/source3/include/libsmb_internal.h
@@ -32,8 +32,6 @@
 #include "libsmb/clirap.h"
 
 #define SMBC_MAX_NAME  1023
-#define SMBC_FILE_MODE (S_IFREG | 0444)
-#define SMBC_DIR_MODE  (S_IFDIR | 0555)
 
 /*
  * DOS Attribute values (used internally)
diff --git a/source3/libsmb/libsmb_stat.c b/source3/libsmb/libsmb_stat.c
index aa0b2dbe2b3..f25ee8f89a3 100644
--- a/source3/libsmb/libsmb_stat.c
+++ b/source3/libsmb/libsmb_stat.c
@@ -59,9 +59,9 @@ void setup_stat(struct stat *st,
 	st->st_mode = 0;
 
 	if (IS_DOS_DIR(attr)) {
-		st->st_mode = SMBC_DIR_MODE;
+		st->st_mode = (S_IFDIR | 0555);
 	} else {
-		st->st_mode = SMBC_FILE_MODE;
+		st->st_mode = (S_IFREG | 0444);
 	}
 
 	if (IS_DOS_ARCHIVE(attr)) {