From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 13 Jul 2021 09:52:20 +0000 (+0200)
Subject: syntax-check: Prohibit 'vir' prefix for enum implementations in virsh
X-Git-Tag: v7.6.0-rc1~113
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=af013aa14c6966f0aebd51e2fcafd52d8910544e;p=thirdparty%2Flibvirt.git

syntax-check: Prohibit 'vir' prefix for enum implementations in virsh

Avoid potential conflict of enum helpers declared in virsh.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 256f9f695a..cedb360bfd 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1717,6 +1717,13 @@ sc_group-qemu-caps:
 	$(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/group-qemu-caps.py \
 		--check --prefix $(top_srcdir)/
 
+sc_prohibit_enum_impl_with_vir_prefix_in_virsh:
+	@prohibit='VIR_ENUM_(IMPL|DECL)\(vir[^s]'			\
+	in_vc_files='tools/virsh.*\.[ch]$$'					\
+	halt='avoid "vir" prefix for enums in virsh'				\
+	  $(_sc_search_regexp)
+
+
 # List all syntax-check exemptions:
 exclude_file_name_regexp--sc_avoid_strcase = ^tools/vsh\.h$$