From: Vsevolod Stakhov <vsevolod@rspamd.com>
Date: Fri, 12 Dec 2025 20:24:26 +0000 (+0000)
Subject: [Fix] Handle connection errors with io_uring backend in HTTP client
X-Git-Tag: 3.14.3~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=af2642b6bd86f8beb75f38669b58ac5dc41029ba;p=thirdparty%2Frspamd.git

[Fix] Handle connection errors with io_uring backend in HTTP client

When using io_uring, POLLERR is reported as both EV_READ and EV_WRITE.
This caused connection failures (e.g., ECONNREFUSED) to be misinterpreted
as early server responses. Check SO_ERROR before attempting to read when
the connection hasn't been established yet.
---

diff --git a/src/libserver/http/http_connection.c b/src/libserver/http/http_connection.c
index 72ad56e76e..e9afe47167 100644
--- a/src/libserver/http/http_connection.c
+++ b/src/libserver/http/http_connection.c
@@ -1006,6 +1006,25 @@ rspamd_http_event_handler(int fd, short what, gpointer ud)
 		/* Check for early response while still sending request (client only) */
 		if (conn->type == RSPAMD_HTTP_CLIENT &&
 			priv->wr_pos < priv->wr_total && priv->wr_total > 0) {
+			/* Check for connection errors (io_uring reports POLLERR as EV_READ) */
+			if (!priv->first_write_done) {
+				int sock_err = 0;
+				socklen_t sock_err_len = sizeof(sock_err);
+
+				if (getsockopt(fd, SOL_SOCKET, SO_ERROR, &sock_err, &sock_err_len) == 0 &&
+					sock_err != 0) {
+					err = g_error_new(HTTP_ERROR, 500,
+									  "Connection failed: %s", strerror(sock_err));
+					conn->error_handler(conn, err);
+					g_error_free(err);
+
+					REF_RELEASE(pbuf);
+					rspamd_http_connection_unref(conn);
+
+					return;
+				}
+			}
+
 			msg_debug("received early server response while still writing request "
 					  "(sent %uz of %uz bytes)",
 					  priv->wr_pos, priv->wr_total);