From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Mon, 18 Apr 2022 22:36:26 +0000 (-0500)
Subject: Leave module_thread_inst_list around if thread instantiation fails
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=af2d6e6439b33527b9ca23de5edbce46c9261977;p=thirdparty%2Ffreeradius-server.git

Leave module_thread_inst_list around if thread instantiation fails
---

diff --git a/src/lib/server/module.c b/src/lib/server/module.c
index 9f37c5934b2..5347d0c17b2 100644
--- a/src/lib/server/module.c
+++ b/src/lib/server/module.c
@@ -654,8 +654,8 @@ int modules_thread_instantiate(TALLOC_CTX *ctx, module_list_t const *ml, fr_even
 		if (mi->module->thread_instantiate &&
 		    mi->module->thread_instantiate(MODULE_THREAD_INST_CTX(mi->dl_inst, ti->data, el)) < 0) {
 			PERROR("Thread instantiation failed for module \"%s\"", mi->name);
+			/* Leave module_thread_inst_list intact, other modules may need to clean up */
 			modules_thread_detach(ml);
-			TALLOC_FREE(module_thread_inst_list);
 			return -1;
 		}