From: 2xsec Date: Wed, 10 Oct 2018 06:00:45 +0000 (+0900) Subject: parse: fix uninitialized pointer access X-Git-Tag: lxc-3.1.0~48^2~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=af5e7ee11b0b3ac00d44e6d64dbf61fdefc58e8c;p=thirdparty%2Flxc.git parse: fix uninitialized pointer access Signed-off-by: 2xsec --- diff --git a/src/lxc/parse.c b/src/lxc/parse.c index 05764b964..2fdb18ec8 100644 --- a/src/lxc/parse.c +++ b/src/lxc/parse.c @@ -81,12 +81,12 @@ int lxc_file_for_each_line_mmap(const char *file, lxc_file_cb callback, void *da ret = fstat(fd, &st); if (ret < 0) { SYSERROR("Failed to stat config file \"%s\"", file); - goto on_error; + goto on_error_fstat; } ret = 0; if (st.st_size == 0) - goto on_error; + goto on_error_fstat; ret = -1; buf = lxc_strmmap(NULL, st.st_size, PROT_READ | PROT_WRITE, @@ -117,6 +117,7 @@ on_error: ret = -1; } +on_error_fstat: saved_errno = errno; close(fd); errno = saved_errno;