From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 11 Feb 2013 21:12:49 +0000 (-0500)
Subject: Fix another memory leak
X-Git-Tag: tor-0.2.4.11-alpha~39^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=afca9ab14ee16b8dcfcde40a13d49f3612138dcb;p=thirdparty%2Ftor.git

Fix another memory leak

This one occurs when changing configuration options. Found by
coverity.
---

diff --git a/src/or/config.c b/src/or/config.c
index 90a5dfbda1..16eadf917b 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -777,9 +777,12 @@ set_options(or_options_t *new_val, char **msg)
         line = get_assigned_option(&options_format, new_val, var_name, 1);
 
         if (line) {
-          for (; line; line = line->next) {
+          config_line_t *next;
+          for (; line; line = next) {
+            next = line->next;
             smartlist_add(elements, line->key);
             smartlist_add(elements, line->value);
+            tor_free(line);
           }
         } else {
           smartlist_add(elements, (char*)options_format.vars[i].name);