From: Ruben Kerkhof <ruben@rubenkerkhof.com>
Date: Sat, 26 May 2018 15:12:41 +0000 (+0200)
Subject: statsd plugin: Comparison is always true because status <= -1
X-Git-Tag: collectd-5.9.0~239
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=afcb4675b3a5f658578702e6a0d8dc3c5063a051;p=thirdparty%2Fcollectd.git

statsd plugin: Comparison is always true because status <= -1

Found by https://lgtm.com
---

diff --git a/src/statsd.c b/src/statsd.c
index 28ee337cf..444e8ea11 100644
--- a/src/statsd.c
+++ b/src/statsd.c
@@ -352,9 +352,8 @@ static int statsd_handle_set(char const *name, /* {{{ */
   status = c_avl_insert(metric->set, set_key, /* value = */ NULL);
   if (status < 0) {
     pthread_mutex_unlock(&metrics_lock);
-    if (status < 0)
-      ERROR("statsd plugin: c_avl_insert (\"%s\") failed with status %i.",
-            set_key, status);
+    ERROR("statsd plugin: c_avl_insert (\"%s\") failed with status %i.",
+          set_key, status);
     sfree(set_key);
     return -1;
   } else if (status > 0) /* key already exists */