From: Luca Boccassi <bluca@debian.org>
Date: Mon, 25 Mar 2024 12:02:20 +0000 (+0000)
Subject: homework: add missing assert
X-Git-Tag: v256-rc1~410^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b0118b2533d699fb188f3a2f198c25b472fed982;p=thirdparty%2Fsystemd.git

homework: add missing assert

'cache' is used unconditionally in this function, so add an assert.

CID#1540860
---

diff --git a/src/home/homework.c b/src/home/homework.c
index afc11422986..6e89daaf015 100644
--- a/src/home/homework.c
+++ b/src/home/homework.c
@@ -56,6 +56,7 @@ int user_record_authenticate(
 
         assert(h);
         assert(secret);
+        assert(cache);
 
         /* Tries to authenticate a user record with the supplied secrets. i.e. checks whether at least one
          * supplied plaintext passwords matches a hashed password field of the user record. Or if a
@@ -78,7 +79,7 @@ int user_record_authenticate(
          * to force re-authentication. */
 
         /* First, let's see if we already have a volume key from the keyring */
-        if (cache && cache->volume_key &&
+        if (cache->volume_key &&
             json_variant_is_blank_object(json_variant_by_key(secret->json, "secret"))) {
                 log_info("LUKS volume key from keyring unlocks user record.");
                 return 1;