From: Jürg Billeter <j@bitron.ch>
Date: Fri, 15 Jul 2016 03:16:46 +0000 (+0200)
Subject: Report internal error for invalid type parameter comparison
X-Git-Tag: 0.33.1~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b0191489cb87d15b7c97bb82af2269de6c80fadb;p=thirdparty%2Fvala.git

Report internal error for invalid type parameter comparison
---

diff --git a/vala/valatypeparameter.vala b/vala/valatypeparameter.vala
index f875f304d..0fa3bd8ed 100644
--- a/vala/valatypeparameter.vala
+++ b/vala/valatypeparameter.vala
@@ -49,6 +49,12 @@ public class Vala.TypeParameter : Symbol {
 	 *              otherwise
 	 */
 	public bool equals (TypeParameter param2) {
-		return name == param2.name && parent_symbol == param2.parent_symbol;
+		/* only type parameters with the same parent are comparable */
+		if (parent_symbol != param2.parent_symbol) {
+			Report.error (source_reference, "internal error: comparing type parameters with different parents");
+			return false;
+		}
+
+		return name == param2.name;
 	}
 }