From: Thierry FOURNIER Date: Tue, 11 Jul 2017 16:38:39 +0000 (+0200) Subject: BUG/MINOR: Lua: The socket may be destroyed when we try to access. X-Git-Tag: v1.8-dev3~110 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b01d28f9766c96ebe4d29b9e8cc0c24c689fc03f;p=thirdparty%2Fhaproxy.git BUG/MINOR: Lua: The socket may be destroyed when we try to access. When we try to access to other proxy context, we must check its existence because haproxy can kill it between the creation and the usage. This patch should be backported in 1.6 and 1.7 --- diff --git a/src/hlua.c b/src/hlua.c index 24e04f20d4..4299487155 100644 --- a/src/hlua.c +++ b/src/hlua.c @@ -2205,6 +2205,11 @@ __LJMP static int hlua_socket_connect(struct lua_State *L) /* Get args. */ socket = MAY_LJMP(hlua_checksocket(L, 1)); + + /* The socket may be destroy. */ + if (!socket->s) + return 0; + ip = MAY_LJMP(luaL_checkstring(L, 2)); if (lua_gettop(L) >= 3) port = MAY_LJMP(luaL_checkinteger(L, 3));