From: Razvan Becheriu <ravan@isc.org>
Date: Tue, 12 Mar 2019 11:20:38 +0000 (+0200)
Subject: removed updateHost benchmark
X-Git-Tag: Kea-1.6.0-beta~217
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b052f971d41d1aeb9006704aae1b58790b78aed6;p=thirdparty%2Fkea.git

removed updateHost benchmark
---

diff --git a/src/lib/dhcpsrv/benchmarks/cql_host_data_source_benchmark.cc b/src/lib/dhcpsrv/benchmarks/cql_host_data_source_benchmark.cc
index 5cba70f2bc..a2a2391694 100644
--- a/src/lib/dhcpsrv/benchmarks/cql_host_data_source_benchmark.cc
+++ b/src/lib/dhcpsrv/benchmarks/cql_host_data_source_benchmark.cc
@@ -87,16 +87,6 @@ BENCHMARK_DEFINE_F(CqlHostDataSourceBenchmark, insertHosts)(benchmark::State& st
     }
 }
 
-/// Defines steps necessary for conducting a benchmark that measures
-/// hosts update.
-BENCHMARK_DEFINE_F(CqlHostDataSourceBenchmark, updateHosts)(benchmark::State& state) {
-    const size_t host_count = state.range(0);
-    while (state.KeepRunning()) {
-        setUpWithInserts(state, host_count);
-        updateHosts();
-    }
-}
-
 /// Defines steps necessary for conducting a benchmark that measures
 /// hosts retrieval by getAll4(hw-addr, duid) call.
 BENCHMARK_DEFINE_F(CqlHostDataSourceBenchmark, getAll)(benchmark::State& state) {
@@ -172,11 +162,6 @@ BENCHMARK_DEFINE_F(CqlHostDataSourceBenchmark, get6Prefix)(benchmark::State& sta
 BENCHMARK_REGISTER_F(CqlHostDataSourceBenchmark, insertHosts)
     ->Range(MIN_HOST_COUNT, MAX_HOST_COUNT)->Unit(UNIT);
 
-/// Defines parameters necessary for running a benchmark that measures
-/// hosts update.
-BENCHMARK_REGISTER_F(CqlHostDataSourceBenchmark, updateHosts)
-    ->Range(MIN_HOST_COUNT, MAX_HOST_COUNT)->Unit(UNIT);
-
 /// Defines parameters necessary for running a benchmark that measures
 /// hosts retrieval by getAll4(hw-addr, duid) call.
 BENCHMARK_REGISTER_F(CqlHostDataSourceBenchmark, getAll)
diff --git a/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.cc b/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.cc
index f85293a79e..14da48701c 100644
--- a/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.cc
+++ b/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.cc
@@ -188,13 +188,6 @@ GenericHostDataSourceBenchmark::insertHosts() {
     }
 }
 
-void
-GenericHostDataSourceBenchmark::updateHosts() {
-    for (HostPtr host : hosts_) {
-        hdsptr_->add(host);
-    }
-}
-
 void
 GenericHostDataSourceBenchmark::benchGetAll() {
     for (HostPtr host : hosts_) {
diff --git a/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.h b/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.h
index 8878ba3d22..9c4d8d0b02 100644
--- a/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.h
+++ b/src/lib/dhcpsrv/benchmarks/generic_host_data_source_benchmark.h
@@ -182,9 +182,6 @@ public:
     /// @brief Inserts all hosts stored in hosts_ into the benchmarked host backend
     void insertHosts();
 
-    /// @brief Updates all hosts stored in hosts_ in the benchmarked host backend
-    void updateHosts();
-
     /// @brief Essential steps required to benchmark the
     ///        getAll(identifier-type, identifier) call.
     void benchGetAll();
diff --git a/src/lib/dhcpsrv/benchmarks/mysql_host_data_source_benchmark.cc b/src/lib/dhcpsrv/benchmarks/mysql_host_data_source_benchmark.cc
index 1d030418ce..9b97f9bdc2 100644
--- a/src/lib/dhcpsrv/benchmarks/mysql_host_data_source_benchmark.cc
+++ b/src/lib/dhcpsrv/benchmarks/mysql_host_data_source_benchmark.cc
@@ -87,16 +87,6 @@ BENCHMARK_DEFINE_F(MySqlHostDataSourceBenchmark, insertHosts)(benchmark::State&
     }
 }
 
-/// Defines steps necessary for conducting a benchmark that measures
-/// hosts update.
-BENCHMARK_DEFINE_F(MySqlHostDataSourceBenchmark, updateHosts)(benchmark::State& state) {
-    const size_t host_count = state.range(0);
-    while (state.KeepRunning()) {
-        setUpWithInserts(state, host_count);
-        updateHosts();
-    }
-}
-
 /// Defines steps necessary for conducting a benchmark that measures
 /// hosts retrieval by getAll4(hw-addr, duid) call.
 BENCHMARK_DEFINE_F(MySqlHostDataSourceBenchmark, getAll)(benchmark::State& state) {
@@ -172,11 +162,6 @@ BENCHMARK_DEFINE_F(MySqlHostDataSourceBenchmark, get6Prefix)(benchmark::State& s
 BENCHMARK_REGISTER_F(MySqlHostDataSourceBenchmark, insertHosts)
     ->Range(MIN_HOST_COUNT, MAX_HOST_COUNT)->Unit(UNIT);
 
-/// Defines parameters necessary for running a benchmark that measures
-/// hosts update.
-BENCHMARK_REGISTER_F(MySqlHostDataSourceBenchmark, updateHosts)
-    ->Range(MIN_HOST_COUNT, MAX_HOST_COUNT)->Unit(UNIT);
-
 /// Defines parameters necessary for running a benchmark that measures
 /// hosts retrieval by getAll4(hw-addr, duid) call.
 BENCHMARK_REGISTER_F(MySqlHostDataSourceBenchmark, getAll)
diff --git a/src/lib/dhcpsrv/benchmarks/pgsql_host_data_source_benchmark.cc b/src/lib/dhcpsrv/benchmarks/pgsql_host_data_source_benchmark.cc
index 1b4c22e360..59c1b27089 100644
--- a/src/lib/dhcpsrv/benchmarks/pgsql_host_data_source_benchmark.cc
+++ b/src/lib/dhcpsrv/benchmarks/pgsql_host_data_source_benchmark.cc
@@ -87,16 +87,6 @@ BENCHMARK_DEFINE_F(PgSqlHostDataSourceBenchmark, insertHosts)(benchmark::State&
     }
 }
 
-/// Defines steps necessary for conducting a benchmark that measures
-/// hosts update.
-BENCHMARK_DEFINE_F(PgSqlHostDataSourceBenchmark, updateHosts)(benchmark::State& state) {
-    const size_t host_count = state.range(0);
-    while (state.KeepRunning()) {
-        setUpWithInserts(state, host_count);
-        updateHosts();
-    }
-}
-
 /// Defines steps necessary for conducting a benchmark that measures
 /// hosts retrieval by getAll4(hw-addr, duid) call.
 BENCHMARK_DEFINE_F(PgSqlHostDataSourceBenchmark, getAll)(benchmark::State& state) {
@@ -172,11 +162,6 @@ BENCHMARK_DEFINE_F(PgSqlHostDataSourceBenchmark, get6Prefix)(benchmark::State& s
 BENCHMARK_REGISTER_F(PgSqlHostDataSourceBenchmark, insertHosts)
     ->Range(MIN_HOST_COUNT, MAX_HOST_COUNT)->Unit(UNIT);
 
-/// Defines parameters necessary for running a benchmark that measures
-/// hosts update.
-BENCHMARK_REGISTER_F(PgSqlHostDataSourceBenchmark, updateHosts)
-    ->Range(MIN_HOST_COUNT, MAX_HOST_COUNT)->Unit(UNIT);
-
 /// Defines parameters necessary for running a benchmark that measures
 /// hosts retrieval by getAll4(hw-addr, duid) call.
 BENCHMARK_REGISTER_F(PgSqlHostDataSourceBenchmark, getAll)