From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 9 Sep 2019 08:41:15 +0000 (+0200)
Subject: virsh: Use virshDomain type in 'inject-nmi'
X-Git-Tag: v5.8.0-rc1~143
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b088e270652be98bee495262b19466daa9a929f0;p=thirdparty%2Flibvirt.git

virsh: Use virshDomain type in 'inject-nmi'

With a nice side-effect of fixing alignment.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 9015c43ba2..9913d703ec 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -8645,17 +8645,15 @@ static const vshCmdOptDef opts_inject_nmi[] = {
 static bool
 cmdInjectNMI(vshControl *ctl, const vshCmd *cmd)
 {
-    virDomainPtr dom;
-    bool ret = true;
+    VIR_AUTOPTR(virshDomain) dom = NULL;
 
     if (!(dom = virshCommandOptDomain(ctl, cmd, NULL)))
         return false;
 
     if (virDomainInjectNMI(dom, 0) < 0)
-            ret = false;
+        return false;
 
-    virshDomainFree(dom);
-    return ret;
+    return true;
 }
 
 /*