From: Martin Kletzander <mkletzan@redhat.com>
Date: Fri, 7 Mar 2014 10:15:39 +0000 (+0100)
Subject: virsh: Prohibit virConnectOpen* functions in virsh
X-Git-Tag: v1.2.3-rc1~185
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b0cf7d64614ea1000424534ebbd5738d254c7410;p=thirdparty%2Flibvirt.git

virsh: Prohibit virConnectOpen* functions in virsh

Addition of vshConnect() makes virConnectOpen() functions obsolete in
virsh.  Thus all virsh-*.[ch] files should be left only with
vshConnect() in the case of need.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/cfg.mk b/cfg.mk
index f52295982c..a2fed11077 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -892,6 +892,12 @@ sc_prohibit_wrong_filename_in_comment:
 	    'actual file name' 1>&2; exit 1; }	                       \
 	fi;
 
+sc_prohibit_virConnectOpen_in_virsh:
+	@prohibit='\bvirConnectOpen[a-zA-Z]* *\('                       \
+	in_vc_files='^tools/virsh-.*\.[ch]$$'                            \
+	halt='Use vshConnect() in virsh instead of virConnectOpen*'     \
+	  $(_sc_search_regexp)
+
 
 # We don't use this feature of maint.mk.
 prev_version_file = /dev/null