From: Roy Marples <roy@marples.name>
Date: Wed, 14 Nov 2012 10:44:26 +0000 (+0000)
Subject: We should check start len >0 as len will be zero at this point.
X-Git-Tag: v5.6.3~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b0d47a8e49d4327805abfb329faf6f28c287fa00;p=thirdparty%2Fdhcpcd.git

We should check start len >0 as len will be zero at this point.
---

diff --git a/dhcp.c b/dhcp.c
index da620705..ca564fcb 100644
--- a/dhcp.c
+++ b/dhcp.c
@@ -440,11 +440,13 @@ ssize_t
 decode_rfc3397(char *out, ssize_t len, int pl, const uint8_t *p)
 {
 	const char *start;
+	ssize_t start_len;
 	const uint8_t *r, *q = p;
 	int count = 0, l, hops;
 	uint8_t ltype;
 
 	start = out;
+	start_len = len;
 	while (q - p < pl) {
 		r = NULL;
 		hops = 0;
@@ -494,7 +496,7 @@ decode_rfc3397(char *out, ssize_t len, int pl, const uint8_t *p)
 	if (out) {
 		if (out != start)
 			*(out - 1) = '\0';
-		else if (len > 0)
+		else if (start_len > 0)
 			*out = '\0';
 	}