From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Thu, 21 Nov 2019 14:28:47 +0000 (+0100)
Subject: lib/utils kr_ranked_rrarray_add(): clarify merging RRs
X-Git-Tag: v4.3.0~1^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b0e05005026230cef3e589e488c88b0d286148d5;p=thirdparty%2Fknot-resolver.git

lib/utils kr_ranked_rrarray_add(): clarify merging RRs
---

diff --git a/lib/utils.c b/lib/utils.c
index cb15f4637..140e8ecb3 100644
--- a/lib/utils.c
+++ b/lib/utils.c
@@ -711,6 +711,9 @@ int kr_ranked_rrarray_add(ranked_rr_array_t *array, const knot_rrset_t *rr,
 		}
 		if (stashed->qry_uid != qry_uid) {
 			break;
+			/* We do not guarantee merging RRs "across" any point that switched
+			 * to processing a different upstream packet (i.e. qry_uid).
+			 * In particular, iterator never returns KR_STATE_YIELD. */
 		}
 		if (!rrsets_match(stashed->rr, rr)) {
 			continue;