From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 18 Jul 2024 07:37:55 +0000 (+0200)
Subject: vircommand: Initialize dryRunStatus to portable EXIT_SUCCESS instead of 0
X-Git-Tag: v10.6.0-rc1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b103200bf3b1de40587badf2b4856fcf856760de;p=thirdparty%2Flibvirt.git

vircommand: Initialize dryRunStatus to portable EXIT_SUCCESS instead of 0

If dry run of a command was requested (virCommandSetDryRun())
then a specified callback is called instead of running actual
command. This is meant to be used in tests. To mimic running the
command as closely as possible the callback can also set exit
status of the command it's implementing. To save some lines
though, the exit status is initialized to 0 so that callback has
to set it only on failures. Now, 0 is not exactly portable value
- that's why stdlib.h has EXIT_SUCCESS (and EXIT_FAILURE) values.
Initialize the exit status (held in dryRunStatus) to EXIT_SUCCESS
then.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
---

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 07bee9b12e..a03fcc37ae 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -2630,7 +2630,7 @@ virCommandRunAsync(virCommand *cmd, pid_t *pid)
 
     if (dryRunBuffer || dryRunCallback) {
         g_autofree char *cmdstr = NULL;
-        dryRunStatus = 0;
+        dryRunStatus = EXIT_SUCCESS;
 
         if (!(cmdstr = virCommandToStringFull(cmd, dryRunBufferArgLinebreaks,
                                               dryRunBufferCommandStripPath)))