From: Amos Jeffries <amosjeffries@squid-cache.org>
Date: Mon, 25 Oct 2010 06:38:54 +0000 (-0600)
Subject: Bug 2808: getRoundRobinParent not handling weights correctly
X-Git-Tag: SQUID_3_1_9~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b114d4bee5497a4f94f55babec3660c9a438d5f3;p=thirdparty%2Fsquid.git

Bug 2808: getRoundRobinParent not handling weights correctly

Suspected fix. Has not been able to be replicated before the change.
---

diff --git a/src/neighbors.cc b/src/neighbors.cc
index f3239ba8a4..e5ea243f6c 100644
--- a/src/neighbors.cc
+++ b/src/neighbors.cc
@@ -320,7 +320,7 @@ getRoundRobinParent(HttpRequest * request)
             if (p->weight == q->weight) {
                 if (q->rr_count < p->rr_count)
                     continue;
-            } else if ( (double) q->rr_count / q->weight < (double) p->rr_count / p->weight) {
+            } else if ( ((double) q->rr_count / q->weight) < ((double) p->rr_count / p->weight)) {
                 continue;
             }
         }