From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 26 Feb 2015 08:03:09 +0000 (+0100)
Subject: conf: error out on missing dhcp host attributes
X-Git-Tag: v1.2.13~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b15b21f3a52945644c7ccbbe1dd51b86d36ca777;p=thirdparty%2Flibvirt.git

conf: error out on missing dhcp host attributes

In virNetworkDHCPHostDefParseXML an error is reported
when partialOkay == true, and none of ip, mac, name
were supplied.

Add the missing goto and error out in this case.
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 52fcf3d2aa..0f4fc1edbc 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -746,6 +746,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName,
                              "must be specified for static host definition "
                              "in network '%s' "),
                            networkName);
+            goto cleanup;
         }
     } else {
         /* normal usage - you need at least name (IPv6) or one of MAC