From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 28 Feb 2023 01:27:48 +0000 (-0500)
Subject: Drop test view when done with it.
X-Git-Tag: REL_15_3~105
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b15db7f6905acb0c40e651bef54d86ffe4b30d39;p=thirdparty%2Fpostgresql.git

Drop test view when done with it.

The view just added by commit 53fe7e6cb decompiles differently
in v15 than HEAD (presumably as a consequence of 47bb9db75).
That causes failures in cross-version upgrade testing.

We could teach AdjustUpgrade.pm to compensate for that, but it
seems less painful to just drop the view after we're done with it.

Per buildfarm.
---

diff --git a/contrib/postgres_fdw/expected/postgres_fdw.out b/contrib/postgres_fdw/expected/postgres_fdw.out
index e1ca8f7082d..16bee3dd32c 100644
--- a/contrib/postgres_fdw/expected/postgres_fdw.out
+++ b/contrib/postgres_fdw/expected/postgres_fdw.out
@@ -11473,6 +11473,9 @@ SELECT count(*) FROM remote_application_name
      1
 (1 row)
 
+-- Clean up.
+DROP FOREIGN TABLE remote_application_name;
+DROP VIEW my_application_name;
 -- ===================================================================
 -- test parallel commit
 -- ===================================================================
diff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/contrib/postgres_fdw/sql/postgres_fdw.sql
index e6ea090a7dc..484304e5832 100644
--- a/contrib/postgres_fdw/sql/postgres_fdw.sql
+++ b/contrib/postgres_fdw/sql/postgres_fdw.sql
@@ -3719,6 +3719,10 @@ SELECT count(*) FROM remote_application_name
       to_hex(pg_backend_pid())
       for current_setting('max_identifier_length')::int);
 
+-- Clean up.
+DROP FOREIGN TABLE remote_application_name;
+DROP VIEW my_application_name;
+
 -- ===================================================================
 -- test parallel commit
 -- ===================================================================