From: Frédéric Buclin Date: Tue, 17 Apr 2012 00:13:34 +0000 (+0200) Subject: Bug 745080: Voting extension causes database deadlocks X-Git-Tag: bugzilla-4.3.1~9 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b1779f28a5f15f7ad39855e07a27fcda19b8d3f1;p=thirdparty%2Fbugzilla.git Bug 745080: Voting extension causes database deadlocks r=glob a=LpSolit --- diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm index 43c5821a7e..b4352fa2f2 100644 --- a/extensions/Voting/Extension.pm +++ b/extensions/Voting/Extension.pm @@ -467,7 +467,10 @@ sub _page_user { } } - $dbh->do('DELETE FROM votes WHERE vote_count <= 0'); + if ($canedit && $bug) { + $dbh->do('DELETE FROM votes WHERE vote_count = 0 AND who = ?', + undef, $who->id); + } $dbh->bz_commit_transaction(); $vars->{'canedit'} = $canedit;