From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Mon, 10 Feb 2014 17:52:49 +0000 (+0100)
Subject: Cleanup
X-Git-Tag: SQUID_3_5_0_1~376^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b181c1df3d387bae20903d81c364d9239f274c45;p=thirdparty%2Fsquid.git

Cleanup
---

diff --git a/src/ClientDelayConfig.h b/src/ClientDelayConfig.h
index cec7190e7e..30cd5abcf9 100644
--- a/src/ClientDelayConfig.h
+++ b/src/ClientDelayConfig.h
@@ -2,6 +2,7 @@
 #define SQUID_CLIENTDELAYCONFIG_H
 
 #include "acl/forward.h"
+
 #include <vector>
 
 class StoreEntry;
diff --git a/src/DelayTagged.h b/src/DelayTagged.h
index 61b6e4c620..f0c15d6a69 100644
--- a/src/DelayTagged.h
+++ b/src/DelayTagged.h
@@ -37,7 +37,6 @@
 #if USE_DELAY_POOLS
 
 #include "auth/Gadgets.h"
-#include "base/Vector.h"
 #include "CompositePoolNode.h"
 #include "DelayBucket.h"
 #include "DelayIdComposite.h"
diff --git a/src/FwdState.cc b/src/FwdState.cc
index d5482e4173..3a8d11e82b 100644
--- a/src/FwdState.cc
+++ b/src/FwdState.cc
@@ -611,7 +611,7 @@ FwdState::retryOrBail()
         if (pconnRace == raceHappened)
             debugs(17, 4, HERE << "retrying the same destination");
         else
-            serverDestinations.shift(); // last one failed. try another.
+            serverDestinations.erase(serverDestinations.begin()); // last one failed. try another.
         startConnectionOrFail();
         return;
     }
diff --git a/src/FwdState.h b/src/FwdState.h
index 5472b5164b..88b5775088 100644
--- a/src/FwdState.h
+++ b/src/FwdState.h
@@ -2,7 +2,6 @@
 #define SQUID_FORWARD_H
 
 #include "base/RefCount.h"
-#include "base/Vector.h"
 #include "comm.h"
 #include "comm/Connection.h"
 #include "err_type.h"
diff --git a/src/HttpHeaderRange.h b/src/HttpHeaderRange.h
index 19874eedb4..41992f29a5 100644
--- a/src/HttpHeaderRange.h
+++ b/src/HttpHeaderRange.h
@@ -32,7 +32,6 @@
 #ifndef SQUID_HTTPHEADERRANGE_H
 #define SQUID_HTTPHEADERRANGE_H
 
-#include "base/Vector.h"
 #include "MemPool.h"
 #include "Packer.h"
 #include "Range.h"
diff --git a/src/PeerSelectState.h b/src/PeerSelectState.h
index f58885edec..3bd6bd196b 100644
--- a/src/PeerSelectState.h
+++ b/src/PeerSelectState.h
@@ -35,7 +35,6 @@
 
 #include "AccessLogEntry.h"
 #include "acl/Checklist.h"
-#include "base/Vector.h"
 #include "cbdata.h"
 #include "comm/forward.h"
 #include "hier_code.h"
diff --git a/src/StoreFileSystem.h b/src/StoreFileSystem.h
index 3e45fefed9..a5410b3c54 100644
--- a/src/StoreFileSystem.h
+++ b/src/StoreFileSystem.h
@@ -31,7 +31,7 @@
 #ifndef SQUID_STOREFILESYSTEM_H
 #define SQUID_STOREFILESYSTEM_H
 
-#include "base/Vector.h"
+#include <vector>
 
 /* ****** DOCUMENTATION ***** */
 
diff --git a/src/adaptation/Config.cc b/src/adaptation/Config.cc
index e6b0a058b6..6007dc4981 100644
--- a/src/adaptation/Config.cc
+++ b/src/adaptation/Config.cc
@@ -36,7 +36,6 @@
 #include "adaptation/History.h"
 #include "adaptation/Service.h"
 #include "adaptation/ServiceGroups.h"
-#include "base/Vector.h"
 #include "ConfigParser.h"
 #include "globals.h"
 #include "HttpReply.h"
diff --git a/src/adaptation/History.h b/src/adaptation/History.h
index 52120671ef..614a875c92 100644
--- a/src/adaptation/History.h
+++ b/src/adaptation/History.h
@@ -3,7 +3,6 @@
 
 #include "adaptation/DynamicGroupCfg.h"
 #include "base/RefCount.h"
-#include "base/Vector.h"
 #include "HttpHeader.h"
 #include "Notes.h"
 #include "SBuf.h"
diff --git a/src/base/Vector.h b/src/base/Vector.h
index d9a0de694c..05d58f1281 100644
--- a/src/base/Vector.h
+++ b/src/base/Vector.h
@@ -32,7 +32,7 @@
 #define SQUID_ARRAY_H
 
 /**
- \todo CLEANUP: this file should be called Vector.h at least, and probably be replaced by STL Vector<C>
+ \todo remove this after replacing with STL
  */
 
 #include "fatal.h"
diff --git a/src/event.h b/src/event.h
index 41b7895891..b6d61aea22 100644
--- a/src/event.h
+++ b/src/event.h
@@ -33,7 +33,6 @@
 #define SQUID_EVENT_H
 
 #include "AsyncEngine.h"
-#include "base/Vector.h"
 #include "MemPool.h"
 
 class StoreEntry;
diff --git a/src/ipc/Coordinator.h b/src/ipc/Coordinator.h
index 69631380a6..507fe90b21 100644
--- a/src/ipc/Coordinator.h
+++ b/src/ipc/Coordinator.h
@@ -6,7 +6,6 @@
 #ifndef SQUID_IPC_COORDINATOR_H
 #define SQUID_IPC_COORDINATOR_H
 
-#include "base/Vector.h"
 #include "ipc/Messages.h"
 #include "ipc/Port.h"
 #include "ipc/SharedListen.h"
diff --git a/src/ipc/Queue.h b/src/ipc/Queue.h
index eca2ca477c..79a7654788 100644
--- a/src/ipc/Queue.h
+++ b/src/ipc/Queue.h
@@ -5,7 +5,6 @@
 #define SQUID_IPC_QUEUE_H
 
 #include "base/InstanceId.h"
-#include "base/Vector.h"
 #include "Debug.h"
 #include "ipc/AtomicWord.h"
 #include "ipc/mem/FlexibleArray.h"
diff --git a/src/tunnel.cc b/src/tunnel.cc
index 22e8249883..3e2257e457 100644
--- a/src/tunnel.cc
+++ b/src/tunnel.cc
@@ -33,7 +33,6 @@
 
 #include "squid.h"
 #include "acl/FilledChecklist.h"
-#include "base/Vector.h"
 #include "CachePeer.h"
 #include "client_side.h"
 #include "client_side_request.h"
@@ -779,7 +778,7 @@ tunnelConnectDone(const Comm::ConnectionPointer &conn, comm_err_t status, int xe
         /* At this point only the TCP handshake has failed. no data has been passed.
          * we are allowed to re-try the TCP-level connection to alternate IPs for CONNECT.
          */
-        tunnelState->serverDestinations.shift();
+        tunnelState->serverDestinations.erase(tunnelState->serverDestinations.begin());
         if (status != COMM_TIMEOUT && tunnelState->serverDestinations.size() > 0) {
             /* Try another IP of this destination host */