From: Richard Guenther <rguenther@suse.de>
Date: Thu, 28 Jun 2012 12:01:16 +0000 (+0000)
Subject: re PR middle-end/53790 (ICE on dereferencing a extern union in asm statement)
X-Git-Tag: releases/gcc-4.6.4~470
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b18d5688abd2966d169a3c2fa0606a6f90783d3a;p=thirdparty%2Fgcc.git

re PR middle-end/53790 (ICE on dereferencing a extern union in asm statement)

2012-06-28  Richard Guenther  <rguenther@suse.de>

	PR middle-end/53790
	* expr.c (expand_expr_real_1): Verify if the type is complete
	before inspecting its size.

	* gcc.dg/torture/pr53790.c: New testcase.

From-SVN: r189048
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 740f812e4987..229718c6c8f9 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2012-06-28  Richard Guenther  <rguenther@suse.de>
+
+	PR middle-end/53790
+	* expr.c (expand_expr_real_1): Verify if the type is complete
+	before inspecting its size.
+
 2012-06-22  Richard Guenther  <rguenther@suse.de>
 
 	* gcov-iov.c: Include bconfig.h and system.h.
diff --git a/gcc/expr.c b/gcc/expr.c
index 83ecc039abf0..e4f6cae80b05 100644
--- a/gcc/expr.c
+++ b/gcc/expr.c
@@ -9184,6 +9184,7 @@ expand_expr_real_1 (tree exp, rtx target, enum machine_mode tmode,
 	orig_op0 = op0
 	  = expand_expr (tem,
 			 (TREE_CODE (TREE_TYPE (tem)) == UNION_TYPE
+			  && COMPLETE_TYPE_P (TREE_TYPE (tem))
 			  && (TREE_CODE (TYPE_SIZE (TREE_TYPE (tem)))
 			      != INTEGER_CST)
 			  && modifier != EXPAND_STACK_PARM
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 33920f8651a2..9b46faa45bb5 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2012-06-28  Richard Guenther  <rguenther@suse.de>
+
+	PR middle-end/53790
+	* gcc.dg/torture/pr53790.c: New testcase.
+
 2012-06-25  Jason Merrill  <jason@redhat.com>
 
 	PR c++/52988
diff --git a/gcc/testsuite/gcc.dg/torture/pr53790.c b/gcc/testsuite/gcc.dg/torture/pr53790.c
new file mode 100644
index 000000000000..0abd3dd83c1b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr53790.c
@@ -0,0 +1,17 @@
+/* { dg-do compile } */
+
+typedef struct s {
+    int value;
+} s_t;
+
+static inline int 
+read(s_t const *var)
+{
+  return var->value;
+}
+
+int main()
+{
+  extern union u extern_var;
+  return read((s_t *)&extern_var);
+}