From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Sat, 1 Oct 2016 13:41:49 +0000 (+0100)
Subject: [Fix] Stop caching records with DNS failures
X-Git-Tag: 1.4.0~344
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b1d9c4d7078acbb79e5427cb1db21ab377bed6ac;p=thirdparty%2Frspamd.git

[Fix] Stop caching records with DNS failures
---

diff --git a/src/plugins/spf.c b/src/plugins/spf.c
index d01f2b4da8..0ce88cea24 100644
--- a/src/plugins/spf.c
+++ b/src/plugins/spf.c
@@ -511,9 +511,9 @@ spf_plugin_callback (struct spf_resolved *record, struct rspamd_task *task,
 				1,
 				NULL);
 	}
-	else if (record && record->elts->len == 0) {
+	else if (record && record->elts->len == 0 && record->temp_failed) {
 		rspamd_task_insert_result (task,
-				spf_module_ctx->symbol_permfail,
+				spf_module_ctx->symbol_dnsfail,
 				1,
 				NULL);
 	}
@@ -524,7 +524,7 @@ spf_plugin_callback (struct spf_resolved *record, struct rspamd_task *task,
 
 			l = spf_record_ref (record);
 
-			if (!record->temp_failed) {
+			if (!record->temp_failed && !record->perm_failed && !record->na) {
 				rspamd_lru_hash_insert (spf_module_ctx->spf_hash,
 						record->domain, l,
 						task->tv.tv_sec, record->ttl);