From: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
Date: Fri, 13 Jul 2018 17:55:05 +0000 (+0530)
Subject: util: audit: use VIR_AUTOFREE instead of VIR_FREE for scalar types
X-Git-Tag: v4.6.0-rc1~217
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b204fbc47e74e4ab5e77595c318250aae685a701;p=thirdparty%2Flibvirt.git

util: audit: use VIR_AUTOFREE instead of VIR_FREE for scalar types

By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/util/viraudit.c b/src/util/viraudit.c
index 0085dc37be..a49d458819 100644
--- a/src/util/viraudit.c
+++ b/src/util/viraudit.c
@@ -97,7 +97,7 @@ void virAuditSend(virLogSourcePtr source,
                   virAuditRecordType type ATTRIBUTE_UNUSED, bool success,
                   const char *fmt, ...)
 {
-    char *str = NULL;
+    VIR_AUTOFREE(char *) str = NULL;
     va_list args;
 
     /* Duplicate later checks, to short circuit & avoid printf overhead
@@ -144,7 +144,6 @@ void virAuditSend(virLogSourcePtr source,
         }
     }
 #endif
-    VIR_FREE(str);
 }
 
 void virAuditClose(void)