From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 28 Sep 2023 23:25:21 +0000 (+1300)
Subject: libcli/security: test_run_condtional_ace: va_end() on errors
X-Git-Tag: tevent-0.16.0~309
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2107889332135fc39c092a8d44ff5b9a0ecdcfb;p=thirdparty%2Fsamba.git

libcli/security: test_run_condtional_ace: va_end() on errors

CID 1545154, CID 1545155.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/security/tests/test_run_conditional_ace.c b/libcli/security/tests/test_run_conditional_ace.c
index f8500275148..c538b7cb55e 100644
--- a/libcli/security/tests/test_run_conditional_ace.c
+++ b/libcli/security/tests/test_run_conditional_ace.c
@@ -77,6 +77,7 @@ static bool fill_token_claims(TALLOC_CTX *mem_ctx,
 						    name,
 						    str);
 		if (claim == NULL) {
+			va_end(args);
 			debug_fail("bad claim: %s\n", str);
 			return false;
 		}
@@ -117,6 +118,7 @@ static bool fill_token_sids(TALLOC_CTX *mem_ctx,
 		sid = sddl_decode_sid(mem_ctx, &str, NULL);
 		if (sid == NULL) {
 			debug_fail("bad SID: %s\n", str);
+			va_end(args);
 			return false;
 		}
 		add_sid_to_array(mem_ctx, sid, list, n);