From: Jeff King Date: Thu, 23 Jan 2025 00:36:13 +0000 (-0500) Subject: path-walk: drop redundant parse_tree() call X-Git-Tag: v2.49.0-rc0~74^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b224e8e36cf22df3c058990cfdd8c1d5c51fc5ae;p=thirdparty%2Fgit.git path-walk: drop redundant parse_tree() call This call to parse_tree() was flagged by Coverity for ignoring the return value. But if we look a little further up the function, we can see that there is already a call to parse_tree_gently(), and we'll return early if that fails. So by this point the tree will always be parsed, and the call is redundant. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/path-walk.c b/path-walk.c index 136ec08fb0..9715a5550e 100644 --- a/path-walk.c +++ b/path-walk.c @@ -126,7 +126,6 @@ static int add_tree_entries(struct path_walk_context *ctx, strbuf_addstr(&path, base_path); base_len = path.len; - parse_tree(tree); init_tree_desc(&desc, &tree->object.oid, tree->buffer, tree->size); while (tree_entry(&desc, &entry)) { struct type_and_oid_list *list;