From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 16 May 2024 23:38:10 +0000 (+1200)
Subject: ldb: don't cast to unsigned for ldb_ascii_toupper()
X-Git-Tag: tdb-1.4.11~555
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b22e1d3207d90f102247d690bfe31db55d7b681e;p=thirdparty%2Fsamba.git

ldb: don't cast to unsigned for ldb_ascii_toupper()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb/common/ldb_utf8.c b/lib/ldb/common/ldb_utf8.c
index b82fd64021b..6891de84101 100644
--- a/lib/ldb/common/ldb_utf8.c
+++ b/lib/ldb/common/ldb_utf8.c
@@ -81,7 +81,7 @@ char *ldb_casefold_default(void *context, TALLOC_CTX *mem_ctx, const char *s, si
 		return NULL;
 	}
 	for (i=0;ret[i];i++) {
-		ret[i] = ldb_ascii_toupper((unsigned char)ret[i]);
+		ret[i] = ldb_ascii_toupper(ret[i]);
 	}
 	return ret;
 }
@@ -195,7 +195,7 @@ char *ldb_attr_casefold(TALLOC_CTX *mem_ctx, const char *s)
 		return NULL;
 	}
 	for (i = 0; ret[i]; i++) {
-		ret[i] = ldb_ascii_toupper((unsigned char)ret[i]);
+		ret[i] = ldb_ascii_toupper(ret[i]);
 	}
 	return ret;
 }