From: Sami Kerola <kerolasa@iki.fi>
Date: Sat, 2 Jul 2016 09:28:55 +0000 (+0100)
Subject: sulogin: remove __nonnull__ function attribute
X-Git-Tag: v2.29-rc1~153
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b236e43ef052fa5d18b72b28338bae2f7f3e8b56;p=thirdparty%2Futil-linux.git

sulogin: remove __nonnull__ function attribute

This change fixes compiler option -Werror=nonnull option warning:

login-utils/sulogin-consoles.c: In function 'append_console':
login-utils/sulogin-consoles.c:324:14: warning: nonnull argument 'consoles'
compared to NULL [-Wnonnull-compare]

The NULL check done with list_empty() looks valid, so  it is best to remove
the function attribute that allows compiler to optimize the check away.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/login-utils/sulogin-consoles.c b/login-utils/sulogin-consoles.c
index 1644da5ce5..595b5165da 100644
--- a/login-utils/sulogin-consoles.c
+++ b/login-utils/sulogin-consoles.c
@@ -311,7 +311,7 @@ out:
  */
 static
 #ifdef __GNUC__
-__attribute__((__nonnull__,__hot__))
+__attribute__((__hot__))
 #endif
 int append_console(struct list_head *consoles, const char *name)
 {