From: Evan Hunt <each@isc.org>
Date: Mon, 3 Feb 2025 19:48:08 +0000 (-0800)
Subject: add missing "failed" message in digdelv test
X-Git-Tag: ondrej/lock-free-qpzone-reads-v1~51^2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b24981ea026f6e314b572c072895af9734604ee9;p=thirdparty%2Fbind9.git

add missing "failed" message in digdelv test

there was a test case that could fail (and did) without logging
the fact.
---

diff --git a/bin/tests/system/digdelv/tests.sh b/bin/tests/system/digdelv/tests.sh
index e5c28faf790..66b20f6b0a2 100644
--- a/bin/tests/system/digdelv/tests.sh
+++ b/bin/tests/system/digdelv/tests.sh
@@ -1483,6 +1483,7 @@ if [ -x "$DELV" ]; then
 
   n=$((n + 1))
   echo_i "check that delv handles REFUSED when chasing DS records ($n)"
+  ret=0
   delv_with_opts @10.53.0.2 +root xxx.example.tld A >delv.out.test$n 2>&1 || ret=1
   grep ";; resolution failed: broken trust chain" delv.out.test$n >/dev/null || ret=1
   if [ $ret -ne 0 ]; then echo_i "failed"; fi
@@ -1490,9 +1491,11 @@ if [ -x "$DELV" ]; then
 
   n=$((n + 1))
   echo_i "check NS output from delv +ns ($n)"
+  ret=0
   delv_with_opts -i +ns +nortrace +nostrace +nomtrace +novtrace +hint=../_common/root.hint ns example >delv.out.test$n || ret=1
   lines=$(awk '$1 == "example." && $4 == "NS" {print}' delv.out.test$n | wc -l)
   [ $lines -eq 2 ] || ret=1
+  if [ $ret -ne 0 ]; then echo_i "failed"; fi
   status=$((status + ret))
 
   n=$((n + 1))